-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26145/
-----------------------------------------------------------
(Updated Oct. 2, 2014, 3:47 p.m.)
Review request for Sqoop.
Changes
-------
remove the class files that got into the RB accidentally. ( discard rev 5, do
not consider it when reviewing)
also renamed the config group related entities
Bugs: SQOOP-1498
https://issues.apache.org/jira/browse/SQOOP-1498
Repository: sqoop-SQOOP-1367
Description
-------
Sqoop2 Repository Object refactoring
- see JIRA for the details on the changes to the model objects MConnector,
MJob, MLink, M*Config
- rename forms to configs
- renames to the db repository to accomodate the renames in models/ fields
- rename validator to reflect that they actually validate configs
Diffs (updated)
-----
client/src/main/java/org/apache/sqoop/client/SqoopClient.java d7e6768
client/src/main/java/org/apache/sqoop/client/request/ConnectorResourceRequest.java
2855de6
client/src/main/java/org/apache/sqoop/client/request/DriverConfigResourceRequest.java
7b2ddc2
client/src/main/java/org/apache/sqoop/client/request/JobResourceRequest.java
fd858ec
client/src/main/java/org/apache/sqoop/client/request/LinkResourceRequest.java
2b784c8
client/src/test/java/org/apache/sqoop/client/TestSqoopClient.java 54ea3d2
common/src/main/java/org/apache/sqoop/json/ConnectorBean.java d726a14
common/src/main/java/org/apache/sqoop/json/DriverConfigBean.java a2cc8b8
common/src/main/java/org/apache/sqoop/json/JobBean.java a3e6071
common/src/main/java/org/apache/sqoop/json/JobValidationBean.java 34c0a4b
common/src/main/java/org/apache/sqoop/json/LinkBean.java 8981ea7
common/src/main/java/org/apache/sqoop/json/LinkValidationBean.java a6a6b65
common/src/main/java/org/apache/sqoop/json/ThrowableBean.java fc63ed4
common/src/main/java/org/apache/sqoop/json/ValidationResultBean.java 89bc8db
common/src/main/java/org/apache/sqoop/json/util/ConfigSerialization.java
PRE-CREATION
common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java
77f6191
common/src/main/java/org/apache/sqoop/json/util/ResourceBundleSerialization.java
20ee5f3
common/src/main/java/org/apache/sqoop/model/Config.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/ConfigClass.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/ConfigUtils.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/ConfigurationClass.java 73374d8
common/src/main/java/org/apache/sqoop/model/ConfigurationGroupClass.java
PRE-CREATION
common/src/main/java/org/apache/sqoop/model/Form.java 4321582
common/src/main/java/org/apache/sqoop/model/FormClass.java 6048d03
common/src/main/java/org/apache/sqoop/model/FormUtils.java ae025ab
common/src/main/java/org/apache/sqoop/model/MConfig.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/MConfigList.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/MConfigType.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/MConnectionForms.java 457ccdb
common/src/main/java/org/apache/sqoop/model/MConnector.java 7999b08
common/src/main/java/org/apache/sqoop/model/MDriverConfig.java 62eb197
common/src/main/java/org/apache/sqoop/model/MForm.java ff94660
common/src/main/java/org/apache/sqoop/model/MFormList.java 9130ada
common/src/main/java/org/apache/sqoop/model/MFormType.java 2f403df
common/src/main/java/org/apache/sqoop/model/MFromConfig.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/MJob.java c9b45a5
common/src/main/java/org/apache/sqoop/model/MJobForms.java 08b9a78
common/src/main/java/org/apache/sqoop/model/MLink.java 6a8c424
common/src/main/java/org/apache/sqoop/model/MLinkConfig.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/MToConfig.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/ModelError.java 470b61c
common/src/main/java/org/apache/sqoop/utils/ClassUtils.java eca9f7e
common/src/main/java/org/apache/sqoop/validation/ConfigValidationError.java
PRE-CREATION
common/src/main/java/org/apache/sqoop/validation/ConfigValidationResult.java
PRE-CREATION
common/src/main/java/org/apache/sqoop/validation/ConfigValidationRunner.java
PRE-CREATION
common/src/main/java/org/apache/sqoop/validation/ConfigValidator.java
PRE-CREATION
common/src/main/java/org/apache/sqoop/validation/Message.java cb55b6a
common/src/main/java/org/apache/sqoop/validation/Validation.java fce6e88
common/src/main/java/org/apache/sqoop/validation/ValidationError.java 264d6e3
common/src/main/java/org/apache/sqoop/validation/ValidationResult.java
ae8f1d1
common/src/main/java/org/apache/sqoop/validation/ValidationRunner.java
f36faf2
common/src/test/java/org/apache/sqoop/json/ConfigTestUtil.java PRE-CREATION
common/src/test/java/org/apache/sqoop/json/TestConnectorBean.java fe75ee0
common/src/test/java/org/apache/sqoop/json/TestDriverConfigBean.java fcce7b5
common/src/test/java/org/apache/sqoop/json/TestJobBean.java 78a3420
common/src/test/java/org/apache/sqoop/json/TestLinkBean.java 9ca6b64
common/src/test/java/org/apache/sqoop/json/TestUtil.java 9875219
common/src/test/java/org/apache/sqoop/json/TestValidationBean.java f5f3389
common/src/test/java/org/apache/sqoop/json/TestValidationResultBean.java
5c094fb
common/src/test/java/org/apache/sqoop/json/util/TestConfigSerialization.java
PRE-CREATION
common/src/test/java/org/apache/sqoop/json/util/TestFormSerialization.java
c4223ec
common/src/test/java/org/apache/sqoop/model/TestConfigUtils.java PRE-CREATION
common/src/test/java/org/apache/sqoop/model/TestFormUtils.java 18c9692
common/src/test/java/org/apache/sqoop/model/TestMAccountableEntity.java
af0f450
common/src/test/java/org/apache/sqoop/model/TestMConfig.java PRE-CREATION
common/src/test/java/org/apache/sqoop/model/TestMConfigList.java PRE-CREATION
common/src/test/java/org/apache/sqoop/model/TestMConnectionForms.java 243fff9
common/src/test/java/org/apache/sqoop/model/TestMConnector.java d8bc94d
common/src/test/java/org/apache/sqoop/model/TestMDriverConfig.java 9c23cc3
common/src/test/java/org/apache/sqoop/model/TestMForm.java 536b650
common/src/test/java/org/apache/sqoop/model/TestMFormList.java b8d3d37
common/src/test/java/org/apache/sqoop/model/TestMJob.java 8f2943e
common/src/test/java/org/apache/sqoop/model/TestMJobConfig.java PRE-CREATION
common/src/test/java/org/apache/sqoop/model/TestMJobForms.java e59b282
common/src/test/java/org/apache/sqoop/model/TestMLink.java 77fa2a9
common/src/test/java/org/apache/sqoop/model/TestMLinkConfig.java PRE-CREATION
common/src/test/java/org/apache/sqoop/validation/TestValidation.java 85e9e1c
common/src/test/java/org/apache/sqoop/validation/TestValidationRunner.java
647abe0
common/src/test/java/org/apache/sqoop/validation/validators/TestClassAvailable.java
62b2e0a
connector/connector-generic-jdbc/.gitignore PRE-CREATION
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnector.java
b4b6966
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnectorUpgrader.java
8deddb0
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExtractor.java
e52610a
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcFromDestroyer.java
d3a893f
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcFromInitializer.java
9d0c178
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcLoader.java
991e686
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcPartitioner.java
6b11228
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcToDestroyer.java
7bed1d9
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcToInitializer.java
5d0ec93
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcValidator.java
ad1ee5c
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/FromJobConfig.java
8b23144
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/FromJobConfiguration.java
b036421
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/FromJobConfigurationGroup.java
PRE-CREATION
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/LinkConfig.java
7b76eeb
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/LinkConfiguration.java
7d614f7
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/LinkConfigurationGroup.java
PRE-CREATION
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ToJobConfig.java
a42a6ec
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ToJobConfiguration.java
ad68681
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ToJobConfigurationGroup.java
PRE-CREATION
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/GenericJdbcExecutorTest.java
1022370
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestExtractor.java
fbdf9c6
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestFromInitializer.java
54e6acf
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestLoader.java
144b92a
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestPartitioner.java
ec75e1e
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestToInitializer.java
a87ce7a
connector/connector-hdfs/.gitignore PRE-CREATION
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConfigUpgrader.java
47b186c
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConnector.java
cd5350e
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsExtractor.java
436d243
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsInitializer.java
c2dc1a5
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsLoader.java
4c546ba
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsPartitioner.java
6828de8
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsValidator.java
dfa3659
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/FromJobConfig.java
2c98051
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/FromJobConfiguration.java
f861237
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/FromJobConfigurationGroup.java
PRE-CREATION
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/LinkConfig.java
b689854
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/LinkConfiguration.java
4970821
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/LinkConfigurationGroup.java
PRE-CREATION
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/ToJobConfig.java
b1308db
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/ToJobConfiguration.java
bba249c
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/ToJobConfigurationGroup.java
PRE-CREATION
connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestExtractor.java
c6d2f90
connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestLoader.java
552a751
connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestPartitioner.java
9d177ec
connector/connector-sdk/.gitignore PRE-CREATION
connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java
3954039
core/src/main/java/org/apache/sqoop/connector/ConnectorHandler.java dbfdc03
core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java c87df84
core/src/main/java/org/apache/sqoop/driver/Driver.java 5297bde
core/src/main/java/org/apache/sqoop/driver/DriverConfigUpgrader.java 8d6eb78
core/src/main/java/org/apache/sqoop/driver/DriverConfigValidator.java
PRE-CREATION
core/src/main/java/org/apache/sqoop/driver/DriverValidator.java 9cc51dd
core/src/main/java/org/apache/sqoop/driver/JobManager.java e91c436
core/src/main/java/org/apache/sqoop/driver/JobRequest.java 63e1e49
core/src/main/java/org/apache/sqoop/driver/configuration/DriverConfigurationGroup.java
PRE-CREATION
core/src/main/java/org/apache/sqoop/driver/configuration/JobConfiguration.java
908a4eb
core/src/main/java/org/apache/sqoop/driver/configuration/LinkConfiguration.java
3202844
core/src/main/java/org/apache/sqoop/driver/configuration/ThrottlingConfig.java
PRE-CREATION
core/src/main/java/org/apache/sqoop/driver/configuration/ThrottlingForm.java
e73007e
core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 3466116
core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java
a743491
core/src/main/java/org/apache/sqoop/repository/Repository.java ea1608a
core/src/main/java/org/apache/sqoop/repository/RepositoryManager.java ae7be82
core/src/main/resources/driver-config.properties 9ec5d9e
core/src/test/java/org/apache/sqoop/driver/TestDriverConfigUpgrader.java
9c39d23
core/src/test/java/org/apache/sqoop/driver/TestJobManager.java aa3af89
core/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.java
19b0023
execution/mapreduce/src/main/java/org/apache/sqoop/job/io/Data.java 83c670c
execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/ConfigurationUtils.java
b533837
execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopDestroyerExecutor.java
aecde40
execution/mapreduce/src/test/java/org/apache/sqoop/job/JobUtils.java b5435ff
execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMapReduce.java
5662120
execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestConfigurationUtils.java
1447e00
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepoError.java
61dc3b4
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java
5dd7970
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java
58eed2d
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java
ad42901
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java
4b95687
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestConnectorHandling.java
15306c2
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestDriverConfigHandling.java
9b18bd3
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInputTypes.java
d744693
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestJobHandling.java
47350ea
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestLinkHandling.java
8dd1ce2
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestSubmissionHandling.java
cf0944d
server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java
d1b6b9a
server/src/main/java/org/apache/sqoop/handler/DriverConfigRequestHandler.java
c0d363e
server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java b61d3f5
server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 23fc9f1
shell/src/main/java/org/apache/sqoop/shell/CloneJobFunction.java 97d8e6f
shell/src/main/java/org/apache/sqoop/shell/CloneLinkFunction.java d9babe0
shell/src/main/java/org/apache/sqoop/shell/CreateJobFunction.java ccfed31
shell/src/main/java/org/apache/sqoop/shell/CreateLinkFunction.java 33d60c8
shell/src/main/java/org/apache/sqoop/shell/ShowConnectorFunction.java 2ba75b4
shell/src/main/java/org/apache/sqoop/shell/ShowDriverConfigFunction.java
e6e1004
shell/src/main/java/org/apache/sqoop/shell/ShowJobFunction.java e3f1f47
shell/src/main/java/org/apache/sqoop/shell/ShowLinkFunction.java f500b9e
shell/src/main/java/org/apache/sqoop/shell/SqoopFunction.java 5d69c2a
shell/src/main/java/org/apache/sqoop/shell/UpdateJobFunction.java 96d1fd8
shell/src/main/java/org/apache/sqoop/shell/UpdateLinkFunction.java 30bb63e
shell/src/main/java/org/apache/sqoop/shell/core/Constants.java 4d3838c
shell/src/main/java/org/apache/sqoop/shell/utils/ConfigDisplayer.java
PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/utils/ConfigFiller.java
PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/utils/ConfigOptions.java
PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/utils/DynamicConfigOptions.java
PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/utils/DynamicFormOptions.java
cc63610
shell/src/main/java/org/apache/sqoop/shell/utils/FormDisplayer.java dcbccef
shell/src/main/java/org/apache/sqoop/shell/utils/FormFiller.java a0a5dc2
shell/src/main/java/org/apache/sqoop/shell/utils/FormOptions.java efd002e
shell/src/main/java/org/apache/sqoop/shell/utils/JobDynamicConfigOptions.java
PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/utils/JobDynamicFormOptions.java
87c0776
shell/src/main/java/org/apache/sqoop/shell/utils/LinkDynamicConfigOptions.java
PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/utils/LinkDynamicFormOptions.java
2952be2
shell/src/main/resources/shell-resource.properties c0f86f7
spi/src/main/java/org/apache/sqoop/connector/spi/RepositoryUpgrader.java
e00b404
spi/src/main/java/org/apache/sqoop/connector/spi/SqoopConnector.java 7b78ba0
spi/src/main/java/org/apache/sqoop/job/etl/Destroyer.java f965bdd
spi/src/main/java/org/apache/sqoop/job/etl/Extractor.java 34f02c9
spi/src/main/java/org/apache/sqoop/job/etl/Initializer.java c9ae540
spi/src/main/java/org/apache/sqoop/job/etl/Loader.java 434dcf6
spi/src/main/java/org/apache/sqoop/job/etl/Partitioner.java 8156762
spi/src/main/java/org/apache/sqoop/validation/Validator.java 894f412
submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java
25255ae
test/src/main/java/org/apache/sqoop/test/minicluster/TomcatSqoopMiniCluster.java
9ecc9da
test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java
6074d36
test/src/main/java/org/apache/sqoop/test/testcases/TomcatTestCase.java
63736ab
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromHDFSToRDBMSTest.java
5e1abc1
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromRDBMSToHDFSTest.java
2dc0613
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/PartitionerTest.java
729f95e
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/TableStagedRDBMSTest.java
562a6a6
test/src/test/java/org/apache/sqoop/integration/server/SubmissionWithDisabledModelObjectsTest.java
507ac53
Diff: https://reviews.apache.org/r/26145/diff/
Testing
-------
mvn test, integration tests
Thanks,
Veena Basavaraj
