----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26295/#review55284 -----------------------------------------------------------
core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java <https://reviews.apache.org/r/26295/#comment95673> why public? I dont think we need to expose it. repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java <https://reviews.apache.org/r/26295/#comment95672> these 2 mthods are the same, existLink/Job exvept the sql query, lets please create one method to reuse it. I am not sure the apis should be public at all, why ? - Veena Basavaraj On Oct. 2, 2014, 4:22 p.m., Abraham Elmahrek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26295/ > ----------------------------------------------------------- > > (Updated Oct. 2, 2014, 4:22 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1477 > https://issues.apache.org/jira/browse/SQOOP-1477 > > > Repository: sqoop-SQOOP-1367 > > > Description > ------- > > commit 450db6146922bc197bb7c3eda375319788d610ba > Author: Abraham Elmahrek <[email protected]> > Date: Thu Oct 2 16:19:21 2014 -0700 > > SQOOP-1477: Sqoop2: Make link and job name unique identifier > > :100644 100644 3466116... e7d4589... M > core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java > :100644 100644 a743491... 792306e... M > core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java > :100644 100644 54e37d9... 2489c58... M > core/src/main/java/org/apache/sqoop/repository/RepositoryError.java > :100644 100644 19b0023... e9a6075... M > core/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.java > :100644 100644 5dd7970... 1ea388f... M > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java > :100644 100644 ad42901... d38d789... M > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java > > > Diffs > ----- > > core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 3466116 > core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java > a743491 > core/src/main/java/org/apache/sqoop/repository/RepositoryError.java 54e37d9 > core/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.java > 19b0023 > > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java > 5dd7970 > > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java > ad42901 > > Diff: https://reviews.apache.org/r/26295/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Abraham Elmahrek > >
