----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26295/#review55403 -----------------------------------------------------------
Ship it! love it.! core/src/main/java/org/apache/sqoop/repository/RepositoryError.java <https://reviews.apache.org/r/26295/#comment95758> I am becoming more picky about everthing! these should say invalid linf configs/ job configs for connector. Please repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java <https://reviews.apache.org/r/26295/#comment95759> nice! I will be adding the same for config table and connfigurable table as well since we will have a separate LINK_TYPE_CONFIG and JOB_TYPE_CONFIG - Veena Basavaraj On Oct. 3, 2014, 11:48 a.m., Abraham Elmahrek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26295/ > ----------------------------------------------------------- > > (Updated Oct. 3, 2014, 11:48 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1477 > https://issues.apache.org/jira/browse/SQOOP-1477 > > > Repository: sqoop-SQOOP-1367 > > > Description > ------- > > commit 450db6146922bc197bb7c3eda375319788d610ba > Author: Abraham Elmahrek <[email protected]> > Date: Thu Oct 2 16:19:21 2014 -0700 > > SQOOP-1477: Sqoop2: Make link and job name unique identifier > > :100644 100644 3466116... e7d4589... M > core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java > :100644 100644 a743491... 792306e... M > core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java > :100644 100644 54e37d9... 2489c58... M > core/src/main/java/org/apache/sqoop/repository/RepositoryError.java > :100644 100644 19b0023... e9a6075... M > core/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.java > :100644 100644 5dd7970... 1ea388f... M > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java > :100644 100644 ad42901... d38d789... M > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java > > > Diffs > ----- > > core/src/main/java/org/apache/sqoop/repository/RepositoryError.java 54e37d9 > > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java > 39702ca > > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java > fc3ec18 > > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java > 951d9b4 > > repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java > bf72626 > > repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestJobHandling.java > 595b1c8 > > repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestLinkHandling.java > 38e632a > > Diff: https://reviews.apache.org/r/26295/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Abraham Elmahrek > >
