----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26609/#review56489 -----------------------------------------------------------
common/src/main/java/org/apache/sqoop/model/ConfigUtils.java <https://reviews.apache.org/r/26609/#comment96845> transcript? not sure if this was intended common/src/main/java/org/apache/sqoop/model/ConfigUtils.java <https://reviews.apache.org/r/26609/#comment96846> might be good to be consistent with getName to avoid names clashes ( different conenctors can have the same class names) http://stackoverflow.com/questions/15202997/what-is-the-difference-between-canonical-name-simple-name-and-class-name-in-jav core/src/main/java/org/apache/sqoop/repository/Repository.java <https://reviews.apache.org/r/26609/#comment96847> please remove the forms in the comments. use configs instead. it took me a lot of time to rename:) core/src/main/java/org/apache/sqoop/repository/Repository.java <https://reviews.apache.org/r/26609/#comment96848> please make a method that can be reused for checking the validation result. core/src/main/java/org/apache/sqoop/repository/Repository.java <https://reviews.apache.org/r/26609/#comment96844> same as above. can we move this to a class, since there is the same duplication below. core/src/main/java/org/apache/sqoop/repository/Repository.java <https://reviews.apache.org/r/26609/#comment96849> please move repeated code to a class core/src/main/java/org/apache/sqoop/repository/Repository.java <https://reviews.apache.org/r/26609/#comment96850> same as above, forms no. core/src/main/java/org/apache/sqoop/repository/Repository.java <https://reviews.apache.org/r/26609/#comment96851> nice, thanks for the join! core/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.java <https://reviews.apache.org/r/26609/#comment96852> curious how is the testing now done? core/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.java <https://reviews.apache.org/r/26609/#comment96853> can we rename this passing to something along the lines of validation ( ValidConfiguration) or core/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.java <https://reviews.apache.org/r/26609/#comment96854> Passing? can we rename it to Validating ..or something along those lines please use a type in the name so its easy to see which type of config is validated. @ConfigurationClass public static class EmptyLinkConfiguration { } @ConfigurationClass public static class EmptyJobConfiguration { } server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java <https://reviews.apache.org/r/26609/#comment96858> so no more driver config validation? server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java <https://reviews.apache.org/r/26609/#comment96855> nice cleanup!. - Veena Basavaraj On Oct. 11, 2014, 2:51 p.m., Jarek Cecho wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26609/ > ----------------------------------------------------------- > > (Updated Oct. 11, 2014, 2:51 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1576 > https://issues.apache.org/jira/browse/SQOOP-1576 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > I've migrated Repository validation structure to the new infra. I've noticed > some code reuse between Repository and Server Handlers, so I've refactored > those to ConfigUtils class. > > > Diffs > ----- > > common/src/main/java/org/apache/sqoop/model/ConfigUtils.java 9e762dc > common/src/main/java/org/apache/sqoop/model/ModelError.java 35a8943 > common/src/test/java/org/apache/sqoop/model/TestConfigUtils.java d5377f8 > core/src/main/java/org/apache/sqoop/repository/Repository.java 95c7a4d > core/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.java > e6e4760 > server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java > 462579c > server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java > 80e65b8 > > Diff: https://reviews.apache.org/r/26609/diff/ > > > Testing > ------- > > Unit tests seems to be passing. > > > Thanks, > > Jarek Cecho > >
