> On Oct. 13, 2014, 9:25 p.m., Veena Basavaraj wrote: > > common/src/main/java/org/apache/sqoop/model/ConfigUtils.java, line 236 > > <https://reviews.apache.org/r/26609/diff/1/?file=719198#file719198line236> > > > > might be good to be consistent with getName > > to avoid names clashes ( different conenctors can have the same class > > names) > > > > http://stackoverflow.com/questions/15202997/what-is-the-difference-between-canonical-name-simple-name-and-class-name-in-jav > > Jarek Cecho wrote: > I'm not sure that I'm following your point with "getName()" on line when > I'm comparing innstance for null. Are you by any chance referring to the line > below when I'm trowing an exception with configClass.getSimpleName()? > > If so, then fixed :)
yes of crs. > On Oct. 13, 2014, 9:25 p.m., Veena Basavaraj wrote: > > core/src/main/java/org/apache/sqoop/repository/Repository.java, line 437 > > <https://reviews.apache.org/r/26609/diff/1/?file=719201#file719201line437> > > > > please make a method that can be reused for checking the validation > > result. > > Jarek Cecho wrote: > Could you elaborate a bit more what you mean? Such method is already > there right? It's the "canProceed()". Or do you see issue with the dual > method call ".getStatus().canProceed()"? I did not mean just the can Proceed() but the complete set of 5 lines, I am not sure which line the comment starts from. but I have added the same comment in rev 2 > On Oct. 13, 2014, 9:25 p.m., Veena Basavaraj wrote: > > server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java, line > > 203 > > <https://reviews.apache.org/r/26609/diff/1/?file=719203#file719203line203> > > > > so no more driver config validation? > > Jarek Cecho wrote: > Not sure that I'm following this point entirely. Could you elaborate? > Perhaps highlighing entire section that caught your eye would help :) this has been addressed in rev 2 - Veena ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26609/#review56489 ----------------------------------------------------------- On Oct. 27, 2014, 2:57 p.m., Jarek Cecho wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26609/ > ----------------------------------------------------------- > > (Updated Oct. 27, 2014, 2:57 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1576 > https://issues.apache.org/jira/browse/SQOOP-1576 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > I've migrated Repository validation structure to the new infra. I've noticed > some code reuse between Repository and Server Handlers, so I've refactored > those to ConfigUtils class. > > > Diffs > ----- > > common/src/main/java/org/apache/sqoop/model/ConfigUtils.java 372e7d3 > common/src/main/java/org/apache/sqoop/model/ModelError.java 35a8943 > common/src/test/java/org/apache/sqoop/model/TestConfigUtils.java 2a7281a > core/src/main/java/org/apache/sqoop/repository/Repository.java bd2a3be > core/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.java > e11fd10 > server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java > 61b1610 > server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java > b715ad3 > > Diff: https://reviews.apache.org/r/26609/diff/ > > > Testing > ------- > > Unit tests seems to be passing. > > > Thanks, > > Jarek Cecho > >
