-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26678/#review57114
-----------------------------------------------------------
For splitting up AuthenticationManager, what I meant was something like the
following:
AuthenticationHandler -> Understands how to do auth.
AuthenticationManager -> gets AuthenticationHandler using factory and
authenticates.
Or something of this nature.
- Abraham Elmahrek
On Oct. 17, 2014, 4 a.m., richard zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26678/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2014, 4 a.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> Kerberos support when starting service
>
>
> Diffs
> -----
>
> core/pom.xml 2b6e436d637eb03493323e5b36e31e433c1f8bbb
>
> core/src/main/java/org/apache/sqoop/authentication/AuthenticationConstants.java
> PRE-CREATION
> core/src/main/java/org/apache/sqoop/authentication/AuthenticationError.java
> PRE-CREATION
>
> core/src/main/java/org/apache/sqoop/authentication/AuthenticationManager.java
> PRE-CREATION
>
> core/src/main/java/org/apache/sqoop/authentication/AuthenticationManagerFactory.java
> PRE-CREATION
>
> core/src/main/java/org/apache/sqoop/authentication/KerberosAuthenticationManager.java
> PRE-CREATION
>
> core/src/main/java/org/apache/sqoop/authentication/SimpleAuthenticationManager.java
> PRE-CREATION
> core/src/main/java/org/apache/sqoop/core/SqoopServer.java
> ac836c7cee010144696ab17645ccd008aed5762d
> dist/src/main/server/conf/sqoop.properties
> bb010166120321899425f84edb8e1ad6512626d2
> pom.xml f25a29f6db673e6080dcd5ccd51bab76ab38bff4
>
> Diff: https://reviews.apache.org/r/26678/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> richard zhou
>
>
