> On Oct. 20, 2014, 9:14 p.m., Veena Basavaraj wrote:
> > connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/configuration/ToFormat.java,
> > line 21
> > <https://reviews.apache.org/r/26963/diff/1/?file=726940#file726940line21>
> >
> > can we be more specific on supported formats for hdfs via kite sdk,
> > since this will evolve as kote sdk evolves with newer formats.
> >
> > Why cant we use a enum class from Kite itself if there is one
>
> Qian Xu wrote:
> Unfortunately, ConfigUtils supports String Map Integer Boolean and Enum
> only. Kite's Format is actually a class.
>
> Veena Basavaraj wrote:
> I am not sure I understand, I mean why not use the Kite sdk format class
> for avro, csv, parquet... if those are standard formats for the kite
>
> why doe we need another class here.
I saw this in hdfs connector.
can we have a common enum in the conenctor sdk, why do we need duplication in
every connector?
/**
* Various supported formats on disk
*/
public enum ToFormat {
/**
* Comma separated text file
*/
TEXT_FILE,
/**
* Sequence file
*/
SEQUENCE_FILE,
}
- Veena
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26963/#review57536
-----------------------------------------------------------
On Oct. 21, 2014, 12:07 a.m., Qian Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26963/
> -----------------------------------------------------------
>
> (Updated Oct. 21, 2014, 12:07 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1588
> https://issues.apache.org/jira/browse/SQOOP-1588
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> Create a basic Kite connector that can write data (i.e. from a jdbc
> connection) to HDFS.
>
> The scope is defined as follows:
> * Destination: HDFS
> * File Format: Avro Parquet and CSV.
> * Compression Codec: Use default
> * Partitioner Strategy: Not supported
> * Column Mapping: Not supported
>
>
> Diffs
> -----
>
> connector/connector-kite/pom.xml PRE-CREATION
>
> connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteConfigUpgrader.java
> PRE-CREATION
>
> connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteConnector.java
> PRE-CREATION
>
> connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteConnectorError.java
> PRE-CREATION
>
> connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteConstants.java
> PRE-CREATION
>
> connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteDatasetExecutor.java
> PRE-CREATION
>
> connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteLoader.java
> PRE-CREATION
>
> connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteToDestroyer.java
> PRE-CREATION
>
> connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteToInitializer.java
> PRE-CREATION
>
> connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteValidator.java
> PRE-CREATION
>
> connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/configuration/LinkConfig.java
> PRE-CREATION
>
> connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/configuration/LinkConfiguration.java
> PRE-CREATION
>
> connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/configuration/ToFormat.java
> PRE-CREATION
>
> connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/configuration/ToJobConfig.java
> PRE-CREATION
>
> connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/configuration/ToJobConfiguration.java
> PRE-CREATION
>
> connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/util/KiteDataTypeUtil.java
> PRE-CREATION
>
> connector/connector-kite/src/main/resources/kite-connector-config.properties
> PRE-CREATION
> connector/connector-kite/src/main/resources/sqoopconnector.properties
> PRE-CREATION
>
> connector/connector-kite/src/test/java/org/apache/sqoop/connector/kite/TestKiteExecutor.java
> PRE-CREATION
>
> connector/connector-kite/src/test/java/org/apache/sqoop/connector/kite/TestKiteLoader.java
> PRE-CREATION
> connector/connector-kite/src/test/resources/log4j.properties PRE-CREATION
> connector/pom.xml e98a0fc
>
> execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopDestroyerExecutor.java
> b385926
> pom.xml f25a29f
> server/pom.xml 67baaa5
> test/pom.xml 7a80710
>
> Diff: https://reviews.apache.org/r/26963/diff/
>
>
> Testing
> -------
>
> New unittests included. All passed.
>
>
> Thanks,
>
> Qian Xu
>
>
