----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26963/#review59430 -----------------------------------------------------------
Ship it! Please fix the remaining ones. Some might be considered nitpicks, but we have to get there to this kind of standards so we dont have someone else joining the team wondering what everything means and what it does. If you disagree, please shoot me an email / ping me we shall work something out together:) connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteConnector.java <https://reviews.apache.org/r/26963/#comment100702> can you add some java docs on this? or is it available somewhere else. I think we need to get more cautious about docs and tests with everyone. I dont mind even linking something off from here if you have suggestions let me know. connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteConnector.java <https://reviews.apache.org/r/26963/#comment100703> thanks for following this guideline of linking a ticket number. connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteDatasetExecutor.java <https://reviews.apache.org/r/26963/#comment100704> is there a ticket for this? or are you waiting for some ont to confirm. create a ticket and add the details there . connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteToDestroyer.java <https://reviews.apache.org/r/26963/#comment100705> please add a comment to this and link to the tciker open for not doing merge in destroy. I would even want us to have 2 methods on destroy. I am going to ping Jarcec on this ticket. Here is the ticket for your review. https://issues.apache.org/jira/browse/SQOOP-1602 This will be miss the cracks if we dont have a todo to revisit. I will update it whent he ticket is resolved. connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/configuration/ToFormat.java <https://reviews.apache.org/r/26963/#comment100706> are you thinking of moving this to SDK so we can share it with other conenctors. DRY! connector/connector-kite/src/main/resources/connector-configs.properties <https://reviews.apache.org/r/26963/#comment100707> its called link ( I fixed it in generid jdbc thi week) connector/connector-kite/src/main/resources/connector-configs.properties <https://reviews.apache.org/r/26963/#comment100708> nice examples man! I love that you give the attention to details. connector/connector-kite/src/test/java/org/apache/sqoop/connector/kite/TestKiteExecutor.java <https://reviews.apache.org/r/26963/#comment100709> cool tests. pom.xml <https://reviews.apache.org/r/26963/#comment100701> nice! I love this library for unit tests I have - Veena Basavaraj On Oct. 30, 2014, 9:48 p.m., Qian Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26963/ > ----------------------------------------------------------- > > (Updated Oct. 30, 2014, 9:48 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1588 > https://issues.apache.org/jira/browse/SQOOP-1588 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > Create a basic Kite connector that can write data (i.e. from a jdbc > connection) to HDFS. > > The scope is defined as follows: > * Destination: HDFS > * File Format: Avro Parquet and CSV. > * Compression Codec: Use default > * Partitioner Strategy: Not supported > * Column Mapping: Not supported > > > Diffs > ----- > > connector/connector-kite/pom.xml PRE-CREATION > > connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteConnector.java > PRE-CREATION > > connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteConnectorConstants.java > PRE-CREATION > > connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteConnectorError.java > PRE-CREATION > > connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteDatasetExecutor.java > PRE-CREATION > > connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteLoader.java > PRE-CREATION > > connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteToDestroyer.java > PRE-CREATION > > connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteToInitializer.java > PRE-CREATION > > connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/configuration/LinkConfig.java > PRE-CREATION > > connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/configuration/LinkConfiguration.java > PRE-CREATION > > connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/configuration/ToFormat.java > PRE-CREATION > > connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/configuration/ToJobConfig.java > PRE-CREATION > > connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/configuration/ToJobConfiguration.java > PRE-CREATION > > connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/util/InputValidation.java > PRE-CREATION > > connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/util/KiteDataTypeUtil.java > PRE-CREATION > connector/connector-kite/src/main/resources/connector-configs.properties > PRE-CREATION > connector/connector-kite/src/main/resources/sqoopconnector.properties > PRE-CREATION > > connector/connector-kite/src/test/java/org/apache/sqoop/connector/kite/TestKiteExecutor.java > PRE-CREATION > > connector/connector-kite/src/test/java/org/apache/sqoop/connector/kite/TestKiteLoader.java > PRE-CREATION > > connector/connector-kite/src/test/java/org/apache/sqoop/connector/kite/TestKiteToDestroyer.java > PRE-CREATION > > connector/connector-kite/src/test/java/org/apache/sqoop/connector/kite/TestKiteToInitializer.java > PRE-CREATION > connector/connector-kite/src/test/resources/log4j.properties PRE-CREATION > connector/pom.xml e98a0fc > pom.xml f25a29f > server/pom.xml 67baaa5 > test/pom.xml 7a80710 > > Diff: https://reviews.apache.org/r/26963/diff/ > > > Testing > ------- > > New unittests included. All passed. > > > Thanks, > > Qian Xu > >
