----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27236/#review58644 -----------------------------------------------------------
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java <https://reviews.apache.org/r/27236/#comment99705> Maybe add an index on name? Maybe cool for a follow up Jira? server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java <https://reviews.apache.org/r/27236/#comment99715> Unrelated change. Pull out into separate jira? server/src/main/java/org/apache/sqoop/handler/DriverRequestHandler.java <https://reviews.apache.org/r/27236/#comment99714> Unrelated change. Pull out into separate jira? server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java <https://reviews.apache.org/r/27236/#comment99702> Can we have some javadocs (doesn't have to be API in its entirety)? server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java <https://reviews.apache.org/r/27236/#comment99716> Is "v1/link/all" supported any more? Or are we switching to 'v1/links'. server/src/main/java/org/apache/sqoop/server/v1/LinksServlet.java <https://reviews.apache.org/r/27236/#comment99712> I don't see any thing about a '/links' api in the attached doc. server/src/main/webapp/WEB-INF/web.xml <https://reviews.apache.org/r/27236/#comment99713> Is this really necessary? I don't see 'v1/links' in the attached design doc? - Abraham Elmahrek On Oct. 27, 2014, 5:58 p.m., Veena Basavaraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27236/ > ----------------------------------------------------------- > > (Updated Oct. 27, 2014, 5:58 p.m.) > > > Review request for Sqoop. > > > Repository: sqoop-sqoop2 > > > Description > ------- > > see JIRA for details. > > > Diffs > ----- > > common/src/main/java/org/apache/sqoop/json/LinkBean.java 2762500 > common/src/main/java/org/apache/sqoop/json/LinksBean.java PRE-CREATION > common/src/test/java/org/apache/sqoop/json/TestLinkBean.java 526ec52 > core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 254ba9e > core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java > 7d78826 > core/src/main/java/org/apache/sqoop/repository/Repository.java bd2a3be > > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java > b4b5f3e > > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java > 0a5b467 > > repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestLinkHandling.java > 37343d3 > server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java > 5b03a8f > server/src/main/java/org/apache/sqoop/handler/DriverRequestHandler.java > be9685b > server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java > b715ad3 > server/src/main/java/org/apache/sqoop/server/v1/ConnectorServlet.java > 781abc3 > server/src/main/java/org/apache/sqoop/server/v1/DriverServlet.java 43454fd > server/src/main/java/org/apache/sqoop/server/v1/LinkServlet.java 20e5009 > server/src/main/java/org/apache/sqoop/server/v1/LinksServlet.java > PRE-CREATION > server/src/main/webapp/WEB-INF/web.xml a6f7b0d > > Diff: https://reviews.apache.org/r/27236/diff/ > > > Testing > ------- > > yes > > > Thanks, > > Veena Basavaraj > >
