> On Oct. 27, 2014, 11:37 a.m., Abraham Elmahrek wrote: > > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java, > > line 806 > > <https://reviews.apache.org/r/27236/diff/2/?file=734314#file734314line806> > > > > Maybe add an index on name? Maybe cool for a follow up Jira?
sure. a follow up jira since it needs a upgrade script as well, and it is optimization feature. > On Oct. 27, 2014, 11:37 a.m., Abraham Elmahrek wrote: > > server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java, > > lines 52-56 > > <https://reviews.apache.org/r/27236/diff/2/?file=734316#file734316line52> > > > > Unrelated change. Pull out into separate jira? sending another one now, if you can commit it.:) > On Oct. 27, 2014, 11:37 a.m., Abraham Elmahrek wrote: > > server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java, > > lines 50-78 > > <https://reviews.apache.org/r/27236/diff/2/?file=734318#file734318line50> > > > > Can we have some javadocs (doesn't have to be API in its entirety)? there is java docs, moved to the servlet since that is the main entry point. > On Oct. 27, 2014, 11:37 a.m., Abraham Elmahrek wrote: > > server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java, line > > 246 > > <https://reviews.apache.org/r/27236/diff/2/?file=734318#file734318line246> > > > > Is "v1/link/all" supported any more? Or are we switching to 'v1/links'. for reasons of the command line client I have not removed any existing features. I have only added new ways so we can deprecate the all feature later > On Oct. 27, 2014, 11:37 a.m., Abraham Elmahrek wrote: > > server/src/main/java/org/apache/sqoop/server/v1/LinksServlet.java, lines > > 44-46 > > <https://reviews.apache.org/r/27236/diff/2/?file=734322#file734322line44> > > > > I don't see any thing about a '/links' api in the attached doc. it is similar to the connectors, might have missed, do you want me to ammend the doc? > On Oct. 27, 2014, 11:37 a.m., Abraham Elmahrek wrote: > > server/src/main/webapp/WEB-INF/web.xml, lines 103-112 > > <https://reviews.apache.org/r/27236/diff/2/?file=734323#file734323line103> > > > > Is this really necessary? I don't see 'v1/links' in the attached design > > doc? same as above, it is good to be consistent and not have different ways for the similar things, the docs might have missed it since I did not proof read it for everything, i hope we are not doing document driven development.! - Veena ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27236/#review58644 ----------------------------------------------------------- On Oct. 27, 2014, 10:58 a.m., Veena Basavaraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27236/ > ----------------------------------------------------------- > > (Updated Oct. 27, 2014, 10:58 a.m.) > > > Review request for Sqoop. > > > Repository: sqoop-sqoop2 > > > Description > ------- > > see JIRA for details. > > > Diffs > ----- > > common/src/main/java/org/apache/sqoop/json/LinkBean.java 2762500 > common/src/main/java/org/apache/sqoop/json/LinksBean.java PRE-CREATION > common/src/test/java/org/apache/sqoop/json/TestLinkBean.java 526ec52 > core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 254ba9e > core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java > 7d78826 > core/src/main/java/org/apache/sqoop/repository/Repository.java bd2a3be > > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java > b4b5f3e > > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java > 0a5b467 > > repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestLinkHandling.java > 37343d3 > server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java > 5b03a8f > server/src/main/java/org/apache/sqoop/handler/DriverRequestHandler.java > be9685b > server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java > b715ad3 > server/src/main/java/org/apache/sqoop/server/v1/ConnectorServlet.java > 781abc3 > server/src/main/java/org/apache/sqoop/server/v1/DriverServlet.java 43454fd > server/src/main/java/org/apache/sqoop/server/v1/LinkServlet.java 20e5009 > server/src/main/java/org/apache/sqoop/server/v1/LinksServlet.java > PRE-CREATION > server/src/main/webapp/WEB-INF/web.xml a6f7b0d > > Diff: https://reviews.apache.org/r/27236/diff/ > > > Testing > ------- > > yes > > > Thanks, > > Veena Basavaraj > >
