-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26609/
-----------------------------------------------------------

(Updated Oct. 27, 2014, 11:24 p.m.)


Review request for Sqoop.


Changes
-------

Renamed the configuration classes in TestJDBCRepository.


Bugs: SQOOP-1576
    https://issues.apache.org/jira/browse/SQOOP-1576


Repository: sqoop-sqoop2


Description
-------

I've migrated Repository validation structure to the new infra. I've noticed 
some code reuse between Repository and Server Handlers, so I've refactored 
those to ConfigUtils class.


Diffs (updated)
-----

  common/src/main/java/org/apache/sqoop/model/ConfigUtils.java 372e7d3 
  common/src/main/java/org/apache/sqoop/model/ModelError.java 35a8943 
  common/src/test/java/org/apache/sqoop/model/TestConfigUtils.java 2a7281a 
  core/src/main/java/org/apache/sqoop/repository/Repository.java bd2a3be 
  core/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.java 
e11fd10 
  server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 61b1610 
  server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java b715ad3 

Diff: https://reviews.apache.org/r/26609/diff/


Testing
-------

Unit tests seems to be passing.


Thanks,

Jarek Cecho

Reply via email to