----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27360/#review59079 -----------------------------------------------------------
Ship it! LGTM connector/connector-generic-jdbc/src/main/resources/generic-jdbc-connector-config.properties <https://reviews.apache.org/r/27360/#comment100371> I'm concerned that our users don't know exactly what's the classpath (i.e. they may not be Java developers) Perhaps "... name of the JDBC driver that... Note: The driver must be in the sqoop lib directory." connector/connector-generic-jdbc/src/main/resources/generic-jdbc-connector-config.properties <https://reviews.apache.org/r/27360/#comment100376> from should be FROM for consistency? (and I think its clearer too) - Gwen Shapira On Oct. 29, 2014, 11:42 p.m., Veena Basavaraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27360/ > ----------------------------------------------------------- > > (Updated Oct. 29, 2014, 11:42 p.m.) > > > Review request for Sqoop and Jarek Cecho. > > > Repository: sqoop-sqoop2 > > > Description > ------- > > see jira > > > Diffs > ----- > > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcToInitializer.java > 1747347 > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/FromJobConfig.java > 12ceb21 > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ToJobConfig.java > 2428601 > > connector/connector-generic-jdbc/src/main/resources/generic-jdbc-connector-config.properties > c535e9b > > connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestToInitializer.java > 243de01 > > Diff: https://reviews.apache.org/r/27360/diff/ > > > Testing > ------- > > yes > > > Thanks, > > Veena Basavaraj > >
