----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27360/#review59103 -----------------------------------------------------------
I think that this patch needs a rebase on HEAD of current sqoop2 branch, I'm getting compilation error: [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:2.3.2:compile (default-compile) on project sqoop-connector-generic-jdbc: Compilation failure [ERROR] /Users/jarcec/apache/sqoop2-vanila/connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcValidator.java:[96,33] cannot find symbol I've removed the GenericJdbcValidator class recently. - Jarek Cecho On Oct. 30, 2014, 12:02 a.m., Veena Basavaraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27360/ > ----------------------------------------------------------- > > (Updated Oct. 30, 2014, 12:02 a.m.) > > > Review request for Sqoop and Jarek Cecho. > > > Repository: sqoop-sqoop2 > > > Description > ------- > > see jira > > > Diffs > ----- > > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcToInitializer.java > 1747347 > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/FromJobConfig.java > 12ceb21 > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ToJobConfig.java > 2428601 > > connector/connector-generic-jdbc/src/main/resources/generic-jdbc-connector-config.properties > c535e9b > > connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestToInitializer.java > 243de01 > > Diff: https://reviews.apache.org/r/27360/diff/ > > > Testing > ------- > > yes > > > Thanks, > > Veena Basavaraj > >
