----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26931/#review59552 -----------------------------------------------------------
I've asked a couple of questions and had one nit. I have a Kerberized server I want to test this on. I'm +1 if it works and the questions are addressed. Great work! client/src/main/java/org/apache/sqoop/client/request/ResourceRequest.java <https://reviews.apache.org/r/26931/#comment100821> NIT: "" not needed client/src/main/java/org/apache/sqoop/client/request/ResourceRequest.java <https://reviews.apache.org/r/26931/#comment100824> I'm curious, are these tokens safe to log? server/pom.xml <https://reviews.apache.org/r/26931/#comment100826> When are these used? - Abraham Elmahrek On Oct. 31, 2014, 7:31 a.m., richard zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26931/ > ----------------------------------------------------------- > > (Updated Oct. 31, 2014, 7:31 a.m.) > > > Review request for Sqoop. > > > Repository: sqoop-sqoop2 > > > Description > ------- > > SQOOP-1527: Kerberos support (SPNEGO) in communication between server and > client > This is an initial patch. > This patch depends on SQOOP-1526, which is under reviewing > (https://reviews.apache.org/r/26678/diff/#) > > > Diffs > ----- > > client/pom.xml b2e221ec3b5398c05fa081989e73cf1f2c4d43e5 > client/src/main/java/org/apache/sqoop/client/request/ResourceRequest.java > c84a83e3fd7c550645bda8cf5a0ecc844ef7721d > core/src/main/java/org/apache/sqoop/security/AuthenticationConstants.java > 645555ffa7fd344e35618dfcfc4a90367d2310e8 > core/src/main/java/org/apache/sqoop/security/AuthenticationError.java > 338db06137b3716efa10bcd521404acf025875df > dist/src/main/server/conf/sqoop.properties > 3ba50ef7a728e7d2d873fd8c537b3fec9fc85a19 > pom.xml b2259cf3d31bf0a11e4ea8fd80692d108a962d17 > server/pom.xml be2ee9ba68b5b5b0d309f5d4aeb13f6e7c07ef5d > server/src/main/java/org/apache/sqoop/filter/SqoopAuthenticationFilter.java > PRE-CREATION > server/src/main/webapp/WEB-INF/web.xml > 6ad90d2f1fb1b79a86f0b406180267cc886ab26d > shell/pom.xml 947eab02b229f734640c30de3a7d45ba86656d58 > > Diff: https://reviews.apache.org/r/26931/diff/ > > > Testing > ------- > > > Thanks, > > richard zhou > >
