----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27679/#review60202 -----------------------------------------------------------
Ship it! Tests for SubmissionBean and JobBean? common/src/test/java/org/apache/sqoop/json/TestConnectorBean.java <https://reviews.apache.org/r/27679/#comment101580> Should probably have TestConnectorsBean as well. common/src/test/java/org/apache/sqoop/json/TestLinkBean.java <https://reviews.apache.org/r/27679/#comment101577> Should probably have TestLinksBean as well. common/src/test/java/org/apache/sqoop/json/TestLinkBean.java <https://reviews.apache.org/r/27679/#comment101567> add new line to separate the two. - Abraham Elmahrek On Nov. 6, 2014, 2:53 p.m., Veena Basavaraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27679/ > ----------------------------------------------------------- > > (Updated Nov. 6, 2014, 2:53 p.m.) > > > Review request for Sqoop. > > > Bugs: SOOOP-1687 > https://issues.apache.org/jira/browse/SOOOP-1687 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > see jira > > > Diffs > ----- > > common/src/main/java/org/apache/sqoop/json/ConnectorBean.java 845cafa > common/src/main/java/org/apache/sqoop/json/JobBean.java efc2efc > common/src/main/java/org/apache/sqoop/json/LinkBean.java ae3a4ff > common/src/main/java/org/apache/sqoop/json/SubmissionBean.java b7bdaad > common/src/test/java/org/apache/sqoop/json/TestConnectorBean.java 308e17e > common/src/test/java/org/apache/sqoop/json/TestLinkBean.java 7c3c921 > > Diff: https://reviews.apache.org/r/27679/diff/ > > > Testing > ------- > > yes, all tests including integ pass > > > Thanks, > > Veena Basavaraj > >
