----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27679/#review60247 -----------------------------------------------------------
Ship it! ``BeanTestUtil`` is missing license header. Otherwise, looks good. - Abraham Elmahrek On Nov. 6, 2014, 8:22 p.m., Veena Basavaraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27679/ > ----------------------------------------------------------- > > (Updated Nov. 6, 2014, 8:22 p.m.) > > > Review request for Sqoop. > > > Bugs: SOOOP-1687 > https://issues.apache.org/jira/browse/SOOOP-1687 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > see jira > > > Diffs > ----- > > common/src/main/java/org/apache/sqoop/json/ConnectorBean.java d7e0cea > common/src/main/java/org/apache/sqoop/json/DriverBean.java 0e3f872 > common/src/main/java/org/apache/sqoop/json/JobBean.java 0c258aa > common/src/main/java/org/apache/sqoop/json/JsonBean.java 8797015 > common/src/main/java/org/apache/sqoop/json/LinkBean.java 368a56c > common/src/main/java/org/apache/sqoop/json/SubmissionBean.java b7bdaad > common/src/test/java/org/apache/sqoop/json/ConfigTestUtil.java 30778f5 > common/src/test/java/org/apache/sqoop/json/TestConnectorBean.java 308e17e > common/src/test/java/org/apache/sqoop/json/TestConnectorsBean.java > PRE-CREATION > common/src/test/java/org/apache/sqoop/json/TestDriverBean.java 8c92aef > common/src/test/java/org/apache/sqoop/json/TestJobBean.java 923ad47 > common/src/test/java/org/apache/sqoop/json/TestJobsBean.java PRE-CREATION > common/src/test/java/org/apache/sqoop/json/TestLinkBean.java 7c7d2ab > common/src/test/java/org/apache/sqoop/json/TestLinksBean.java PRE-CREATION > common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java c5b8781 > common/src/test/java/org/apache/sqoop/json/util/BeanTestUtil.java > PRE-CREATION > common/src/test/java/org/apache/sqoop/json/util/ConfigTestUtil.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/27679/diff/ > > > Testing > ------- > > yes, all tests including integ pass > > > Thanks, > > Veena Basavaraj > >
