----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28463/#review63096 -----------------------------------------------------------
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java <https://reviews.apache.org/r/28463/#comment105261> nm, seems like we dont have a check to not enter this code path if the version is already the current version, ! repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestRespositorySchemaUpgrade.java <https://reviews.apache.org/r/28463/#comment105260> so on fresh install there is no repo, hence a version = 0, upgrade is done and repo version is set to 4 . Next we restart and repo version is 4, it is hard to capture this in a test case. So I am not clear what we will be asserting. Second, calling both of these, is not going to help super.createOrUpgradeSchemaForLatestVersion(); 58 handler.createOrUpgradeRepository(getDerbyDatabaseConnection()); - Veena Basavaraj On Nov. 25, 2014, 6:49 p.m., Qian Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28463/ > ----------------------------------------------------------- > > (Updated Nov. 25, 2014, 6:49 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1812 > https://issues.apache.org/jira/browse/SQOOP-1812 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > Unexpected behaviour: Sqoop2 server tries to add an existing constraint > repeatedly. > > > Diffs > ----- > > > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java > 907978f > > repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestRespositorySchemaUpgrade.java > 928c34a > > Diff: https://reviews.apache.org/r/28463/diff/ > > > Testing > ------- > > Added a test case to guard the scenario > > > Thanks, > > Qian Xu > >
