----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28676/#review63825 -----------------------------------------------------------
common/src/main/java/org/apache/sqoop/json/SubmissionBean.java <https://reviews.apache.org/r/28676/#comment106137> failure-info? core/src/main/java/org/apache/sqoop/driver/JobManager.java <https://reviews.apache.org/r/28676/#comment106136> The variable naming here is a bit confusing to me. submissionId and externalId seem different. 'submissionId' seems like it would be used in Sqoop and 'externalId' seems like it would be used outside of sqoop. - Abraham Elmahrek On Dec. 3, 2014, 9:34 p.m., Veena Basavaraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28676/ > ----------------------------------------------------------- > > (Updated Dec. 3, 2014, 9:34 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1839 > https://issues.apache.org/jira/browse/SQOOP-1839 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > see jira > > > Diffs > ----- > > common/src/main/java/org/apache/sqoop/json/SubmissionBean.java e926f02 > common/src/main/java/org/apache/sqoop/model/MSubmission.java 2648712 > core/src/main/java/org/apache/sqoop/driver/JobManager.java d6efa6d > core/src/main/java/org/apache/sqoop/driver/JobRequest.java eed79a5 > core/src/main/java/org/apache/sqoop/driver/SubmissionEngine.java 3a32e9f > > submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java > 631ceca > > Diff: https://reviews.apache.org/r/28676/diff/ > > > Testing > ------- > > > Thanks, > > Veena Basavaraj > >
