> On Dec. 4, 2014, 3:24 p.m., Jarek Cecho wrote: > > I'm wondering what are your thoughts for adding a new entry into the > > MSubmission class Veena? > > > > We already do have two entries associated with exceptions from the Job > > execution - exceptionInfo and exceptionStackTrace [1]. As far as I can tell > > we're already using them to propage exceptions from the execution engine on > > job submission [2], so I'm wondering why not use the same entries for > > exceptions that occurs post submission? > > > > 1: > > https://github.com/apache/sqoop/blob/sqoop2/common/src/main/java/org/apache/sqoop/model/MSubmission.java#L90 > > 2: > > https://github.com/apache/sqoop/blob/sqoop2/submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java#L255 > > Veena Basavaraj wrote: > it is not an exception. Failure and Exceptions should be treated > diffeently. > > Jarek Cecho wrote: > Hadoop is actually usually returning a StackTrace as part of the > "failure" call, so they are pretty much equivalent as far as I know. > > I don't think that it make sense to have two entities for different error > states for external system when only one of them can be possibly filled at > the same time. If we don't like the name, we could rename it to something > more general, but having two entries doesn't seem needed. It's an external > system after all, so putting any semantics to that error might break on next > Hadoop (or Spark) version. > > Veena Basavaraj wrote: > Does failure Info have the stack trace? If yes, if it is all in one field > then great. > > I am fine with one field, as long as it is geeneric name and we can have > one field. What is info and stack trace separately buying us?
Talking from my experience, then yes the failure info usually contains stack trace (that is quite frequently truncated though as they have very small fixed size buffer for the exception). The idea for having separate exceptionInfo and exceptionStack trace was primary in presentation. The info should be brief (one line), whereas the exceptionStackTrace is entire multi-line exception trace. For example we're putting the exception message into "exceptionInfo" and stacktrace into stacktrace. As the getFailureInfo is giving us only one thing, we might either put some generic text into the exceptionInfo or copy there the first line from getFailureInfo call. I'm sure that there are other ideas as well :) - Jarek ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28676/#review63851 ----------------------------------------------------------- On Dec. 3, 2014, 9:34 p.m., Veena Basavaraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28676/ > ----------------------------------------------------------- > > (Updated Dec. 3, 2014, 9:34 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1839 > https://issues.apache.org/jira/browse/SQOOP-1839 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > see jira > > > Diffs > ----- > > common/src/main/java/org/apache/sqoop/json/SubmissionBean.java e926f02 > common/src/main/java/org/apache/sqoop/model/MSubmission.java 2648712 > core/src/main/java/org/apache/sqoop/driver/JobManager.java d6efa6d > core/src/main/java/org/apache/sqoop/driver/JobRequest.java eed79a5 > core/src/main/java/org/apache/sqoop/driver/SubmissionEngine.java 3a32e9f > > submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java > 631ceca > > Diff: https://reviews.apache.org/r/28676/diff/ > > > Testing > ------- > > > Thanks, > > Veena Basavaraj > >
