----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28743/#review63973 -----------------------------------------------------------
connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java <https://reviews.apache.org/r/28743/#comment106349> not sure we should do this trickery here. see https://issues.apache.org/jira/browse/SQOOP-1846 - Veena Basavaraj On Dec. 4, 2014, 11:12 p.m., Qian Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28743/ > ----------------------------------------------------------- > > (Updated Dec. 4, 2014, 11:12 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1845 > https://issues.apache.org/jira/browse/SQOOP-1845 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > test testDateTimeISO8601Alternative in TestCSVIntermediateDataFormat > > assertEquals("2014-10-01T12:00:00.000-07:00", > dataFormat.getObjectData()[0].toString()); > > failed with such error message: > > org.junit.ComparisonFailure: > Expected :2014-10-01T12:00:00.000-07:00 > Actual :2014-10-01T12:00:00.000+08:00 > > seems issue of a different timezone, you are @ -7, and I am @ +8. > > Actually the timezone designiator should not be hard coded. > > > Diffs > ----- > > > connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java > bf15c69 > > Diff: https://reviews.apache.org/r/28743/diff/ > > > Testing > ------- > > Changed test cases. > > > Thanks, > > Qian Xu > >
