> On Dec. 5, 2014, 3:23 p.m., Veena Basavaraj wrote: > > connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java, > > line 842 > > <https://reviews.apache.org/r/28743/diff/1/?file=783542#file783542line842> > > > > not sure we should do this trickery here. > > > > see https://issues.apache.org/jira/browse/SQOOP-1846
As I noted in description, some unittests were failed because timezone indicator was hard coded as "-07:00". It didn't be detected by ASF bot, because the build machine is in the same timezone as the developer machine. SQOOP-1846 starts a very good discuss of sqoop's datetime representation standard, whether use iso8601 is not discussed yet. So for SQOOP-1845, I'd rather not add a "T" into any input datetime string. - Qian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28743/#review63973 ----------------------------------------------------------- On Dec. 5, 2014, 3:12 p.m., Qian Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28743/ > ----------------------------------------------------------- > > (Updated Dec. 5, 2014, 3:12 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1845 > https://issues.apache.org/jira/browse/SQOOP-1845 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > test testDateTimeISO8601Alternative in TestCSVIntermediateDataFormat > > assertEquals("2014-10-01T12:00:00.000-07:00", > dataFormat.getObjectData()[0].toString()); > > failed with such error message: > > org.junit.ComparisonFailure: > Expected :2014-10-01T12:00:00.000-07:00 > Actual :2014-10-01T12:00:00.000+08:00 > > seems issue of a different timezone, you are @ -7, and I am @ +8. > > Actually the timezone designiator should not be hard coded. > > > Diffs > ----- > > > connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java > bf15c69 > > Diff: https://reviews.apache.org/r/28743/diff/ > > > Testing > ------- > > Changed test cases. > > > Thanks, > > Qian Xu > >
