----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28745/#review63979 -----------------------------------------------------------
connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java <https://reviews.apache.org/r/28745/#comment106352> I'd suggest to remove hard code timezone from test code and we close sqoop-1845. - Qian Xu On Dec. 5, 2014, 3:30 p.m., Veena Basavaraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28745/ > ----------------------------------------------------------- > > (Updated Dec. 5, 2014, 3:30 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1846 > https://issues.apache.org/jira/browse/SQOOP-1846 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > - fix the expected datetime in SQOOP to be in iso8601 format. this should be > the spec, since we use JODA and it uses iso8601 > > - also as per the spec, the time need not support timezone, hence removing it > > > Diffs > ----- > > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormat.java > d481cce > > connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java > b348ed8 > > Diff: https://reviews.apache.org/r/28745/diff/ > > > Testing > ------- > > > Thanks, > > Veena Basavaraj > >
