> On Dec. 5, 2014, 12:44 a.m., Qian Xu wrote: > > connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java, > > line 441 > > <https://reviews.apache.org/r/28745/diff/1/?file=783563#file783563line441> > > > > I'd suggest to remove hard code timezone from test code and we close > > sqoop-1845.
not sure I understand you comment completely. But the current resolution is tha tthe object.toString will have T in it. Cant help it. but the test will just compare the objects and not to string. see updated patch - Veena ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28745/#review63979 ----------------------------------------------------------- On Dec. 4, 2014, 11:30 p.m., Veena Basavaraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28745/ > ----------------------------------------------------------- > > (Updated Dec. 4, 2014, 11:30 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1846 > https://issues.apache.org/jira/browse/SQOOP-1846 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > - fix the expected datetime in SQOOP to be in iso8601 format. this should be > the spec, since we use JODA and it uses iso8601 > > - also as per the spec, the time need not support timezone, hence removing it > > > Diffs > ----- > > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormat.java > d481cce > > connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java > b348ed8 > > Diff: https://reviews.apache.org/r/28745/diff/ > > > Testing > ------- > > > Thanks, > > Veena Basavaraj > >
