----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28802/#review64237 -----------------------------------------------------------
Did an initial review... found a couple of small things. Good first go at it! Also, I still need to try this out on my machine! connector/connector-kafka/src/main/java/org/apache/sqoop/connector/kafka/KafkaConnectorErrors.java <https://reviews.apache.org/r/28802/#comment106876> 0000? connector/connector-kafka/src/main/java/org/apache/sqoop/connector/kafka/KafkaToDestroyer.java <https://reviews.apache.org/r/28802/#comment106875> Log that it's running? connector/connector-kafka/src/main/java/org/apache/sqoop/connector/kafka/KafkaToInitializer.java <https://reviews.apache.org/r/28802/#comment106877> Log that it ran? connector/connector-kafka/src/main/java/org/apache/sqoop/connector/kafka/configuration/JobConfiguration.java <https://reviews.apache.org/r/28802/#comment106872> ToJobConfiguration? connector/connector-kafka/src/main/java/org/apache/sqoop/connector/kafka/configuration/LinkConfig.java <https://reviews.apache.org/r/28802/#comment106874> Add a CSV validator possibly? connector/connector-kafka/src/main/java/org/apache/sqoop/connector/kafka/configuration/LinkConfig.java <https://reviews.apache.org/r/28802/#comment106873> Comma separated list? Maybe add a CSV validator. - Abraham Elmahrek On Dec. 8, 2014, 2:35 p.m., Gwen Shapira wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28802/ > ----------------------------------------------------------- > > (Updated Dec. 8, 2014, 2:35 p.m.) > > > Review request for Sqoop. > > > Repository: sqoop-sqoop2 > > > Description > ------- > > SQOOP-1852: Sqoop2: Kafka connector supporting TO direction > > > Diffs > ----- > > connector/connector-kafka/pom.xml PRE-CREATION > > connector/connector-kafka/src/main/java/org/apache/sqoop/connector/kafka/KafkaConnector.java > PRE-CREATION > > connector/connector-kafka/src/main/java/org/apache/sqoop/connector/kafka/KafkaConnectorErrors.java > PRE-CREATION > > connector/connector-kafka/src/main/java/org/apache/sqoop/connector/kafka/KafkaConstants.java > PRE-CREATION > > connector/connector-kafka/src/main/java/org/apache/sqoop/connector/kafka/KafkaLoader.java > PRE-CREATION > > connector/connector-kafka/src/main/java/org/apache/sqoop/connector/kafka/KafkaToDestroyer.java > PRE-CREATION > > connector/connector-kafka/src/main/java/org/apache/sqoop/connector/kafka/KafkaToInitializer.java > PRE-CREATION > > connector/connector-kafka/src/main/java/org/apache/sqoop/connector/kafka/configuration/JobConfig.java > PRE-CREATION > > connector/connector-kafka/src/main/java/org/apache/sqoop/connector/kafka/configuration/JobConfiguration.java > PRE-CREATION > > connector/connector-kafka/src/main/java/org/apache/sqoop/connector/kafka/configuration/LinkConfig.java > PRE-CREATION > > connector/connector-kafka/src/main/java/org/apache/sqoop/connector/kafka/configuration/LinkConfiguration.java > PRE-CREATION > > connector/connector-kafka/src/main/resources/kafka-connector-config.properties > PRE-CREATION > connector/connector-kafka/src/main/resources/sqoopconnector.properties > PRE-CREATION > > connector/connector-kafka/src/test/java/org/apache/sqoop/connector/kafka/TestKafkaLoader.java > PRE-CREATION > > connector/connector-kafka/src/test/java/org/apache/sqoop/connector/kafka/utils/KafkaConsumer.java > PRE-CREATION > > connector/connector-kafka/src/test/java/org/apache/sqoop/connector/kafka/utils/KafkaLocal.java > PRE-CREATION > > connector/connector-kafka/src/test/java/org/apache/sqoop/connector/kafka/utils/TestUtil.java > PRE-CREATION > > connector/connector-kafka/src/test/java/org/apache/sqoop/connector/kafka/utils/ZooKeeperLocal.java > PRE-CREATION > connector/connector-kafka/src/test/resources/kafka-server.properties > PRE-CREATION > connector/connector-kafka/src/test/resources/log4j.properties PRE-CREATION > connector/pom.xml da4ed3e > pom.xml e182176 > > Diff: https://reviews.apache.org/r/28802/diff/ > > > Testing > ------- > > Unit tests only for now. > > > Thanks, > > Gwen Shapira > >
