----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28802/#review64472 -----------------------------------------------------------
Looks good. There are a few places where System.out.println is used as logging I think. Can we replace it with a logger? common-test/src/main/java/org/apache/sqoop/common/test/kafka/KafkaConsumer.java <https://reviews.apache.org/r/28802/#comment107238> 10 seconds or 1 second? common-test/src/main/java/org/apache/sqoop/common/test/kafka/TestUtil.java <https://reviews.apache.org/r/28802/#comment107189> IT seems like zkLocalPort should be here? common-test/src/main/java/org/apache/sqoop/common/test/kafka/TestUtil.java <https://reviews.apache.org/r/28802/#comment107239> Follow up: randomize? common-test/src/main/java/org/apache/sqoop/common/test/kafka/ZooKeeperLocal.java <https://reviews.apache.org/r/28802/#comment107190> LOG.error()? connector/connector-kafka/src/main/java/org/apache/sqoop/connector/kafka/KafkaLoader.java <https://reviews.apache.org/r/28802/#comment107240> Logging? pom.xml <https://reviews.apache.org/r/28802/#comment107193> Is it possible to handle this similar to Hadoop (scope provided)? - Abraham Elmahrek On Dec. 9, 2014, 11:31 p.m., Gwen Shapira wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28802/ > ----------------------------------------------------------- > > (Updated Dec. 9, 2014, 11:31 p.m.) > > > Review request for Sqoop. > > > Repository: sqoop-sqoop2 > > > Description > ------- > > SQOOP-1852: Sqoop2: Kafka connector supporting TO direction > > > Diffs > ----- > > common-test/pom.xml 9fd671c > > common-test/src/main/java/org/apache/sqoop/common/test/kafka/KafkaConsumer.java > PRE-CREATION > > common-test/src/main/java/org/apache/sqoop/common/test/kafka/KafkaLocal.java > PRE-CREATION > common-test/src/main/java/org/apache/sqoop/common/test/kafka/TestUtil.java > PRE-CREATION > > common-test/src/main/java/org/apache/sqoop/common/test/kafka/ZooKeeperLocal.java > PRE-CREATION > connector/connector-kafka/pom.xml PRE-CREATION > > connector/connector-kafka/src/main/java/org/apache/sqoop/connector/kafka/KafkaConnector.java > PRE-CREATION > > connector/connector-kafka/src/main/java/org/apache/sqoop/connector/kafka/KafkaConnectorErrors.java > PRE-CREATION > > connector/connector-kafka/src/main/java/org/apache/sqoop/connector/kafka/KafkaConstants.java > PRE-CREATION > > connector/connector-kafka/src/main/java/org/apache/sqoop/connector/kafka/KafkaLoader.java > PRE-CREATION > > connector/connector-kafka/src/main/java/org/apache/sqoop/connector/kafka/KafkaToDestroyer.java > PRE-CREATION > > connector/connector-kafka/src/main/java/org/apache/sqoop/connector/kafka/KafkaToInitializer.java > PRE-CREATION > > connector/connector-kafka/src/main/java/org/apache/sqoop/connector/kafka/configuration/LinkConfig.java > PRE-CREATION > > connector/connector-kafka/src/main/java/org/apache/sqoop/connector/kafka/configuration/LinkConfiguration.java > PRE-CREATION > > connector/connector-kafka/src/main/java/org/apache/sqoop/connector/kafka/configuration/ToJobConfig.java > PRE-CREATION > > connector/connector-kafka/src/main/java/org/apache/sqoop/connector/kafka/configuration/ToJobConfiguration.java > PRE-CREATION > > connector/connector-kafka/src/main/resources/kafka-connector-config.properties > PRE-CREATION > connector/connector-kafka/src/main/resources/sqoopconnector.properties > PRE-CREATION > > connector/connector-kafka/src/test/java/org/apache/sqoop/connector/kafka/TestConfigValidator.java > PRE-CREATION > > connector/connector-kafka/src/test/java/org/apache/sqoop/connector/kafka/TestKafkaLoader.java > PRE-CREATION > connector/pom.xml da4ed3e > pom.xml e182176 > server/pom.xml 1adcca0 > server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java > dc237b8 > test/pom.xml eedb545 > > test/src/main/java/org/apache/sqoop/test/testcases/KafkaConnectorTestCase.java > PRE-CREATION > > test/src/test/java/org/apache/sqoop/integration/connector/kafka/FromRDBMSToKafkaTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/28802/diff/ > > > Testing > ------- > > Unit tests only for now. > > > Thanks, > > Gwen Shapira > >
