----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29140/#review65282 -----------------------------------------------------------
Cool feature.! common/src/main/java/org/apache/sqoop/schema/ByteArraySchema.java <https://reviews.apache.org/r/29140/#comment108360> prefix name of the column with the schema name, to be unique, but may not be a actual problem, since static final would be nice. common/src/main/java/org/apache/sqoop/schema/ByteArraySchema.java <https://reviews.apache.org/r/29140/#comment108361> a note to myself, why even allow empty names, will fix it someday connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java <https://reviews.apache.org/r/29140/#comment108362> there is TestMatching class , I wonder if tha is the right place for this code. IDF shuld only validate the schema object and not mathing. test/src/test/java/org/apache/sqoop/integration/connector/kafka/FromHDFSToKafkaTest.java <https://reviews.apache.org/r/29140/#comment108363> cool test! - Veena Basavaraj On Dec. 16, 2014, 6:34 p.m., Gwen Shapira wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29140/ > ----------------------------------------------------------- > > (Updated Dec. 16, 2014, 6:34 p.m.) > > > Review request for Sqoop and Veena Basavaraj. > > > Repository: sqoop-sqoop2 > > > Description > ------- > > Using a schema with single binary object to allow data transfer between > schemaless connectors > > > Diffs > ----- > > common/src/main/java/org/apache/sqoop/schema/ByteArraySchema.java > PRE-CREATION > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/matcher/Matcher.java > 8ab13181eba1c68b9734227f9971e3720fdef28d > > connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java > f6852a082f145cdc5b51bf9bf3e3e283f5a277eb > > test/src/main/java/org/apache/sqoop/test/testcases/KafkaConnectorTestCase.java > 41d43c02ff529fc716b3b3f43060653e5ca7fb04 > > test/src/test/java/org/apache/sqoop/integration/connector/kafka/FromHDFSToKafkaTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/29140/diff/ > > > Testing > ------- > > Unit and integration tests > > > Thanks, > > Gwen Shapira > >
