> On Dec. 17, 2014, 3:41 a.m., Veena Basavaraj wrote: > > common/src/main/java/org/apache/sqoop/schema/ByteArraySchema.java, line 34 > > <https://reviews.apache.org/r/29140/diff/2/?file=793545#file793545line34> > > > > prefix name of the column with the schema name, to be unique, but may > > not be a actual problem, since > > > > static final would be nice.
Good point. much cleaner this way. > On Dec. 17, 2014, 3:41 a.m., Veena Basavaraj wrote: > > connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java, > > line 1112 > > <https://reviews.apache.org/r/29140/diff/2/?file=793547#file793547line1112> > > > > there is TestMatching class , I wonder if tha is the right place for > > this code. IDF shuld only validate the schema object and not mathing. > > Veena Basavaraj wrote: > Yeah I doubl checked, Please move the test there, we are all good then Good find. I didn't realize the tests were separate. - Gwen ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29140/#review65282 ----------------------------------------------------------- On Dec. 17, 2014, 5 a.m., Gwen Shapira wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29140/ > ----------------------------------------------------------- > > (Updated Dec. 17, 2014, 5 a.m.) > > > Review request for Sqoop and Veena Basavaraj. > > > Repository: sqoop-sqoop2 > > > Description > ------- > > Using a schema with single binary object to allow data transfer between > schemaless connectors > > > Diffs > ----- > > common/src/main/java/org/apache/sqoop/schema/ByteArraySchema.java > PRE-CREATION > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/matcher/Matcher.java > 8ab1318 > execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMatching.java > 1692ddb > > test/src/main/java/org/apache/sqoop/test/testcases/KafkaConnectorTestCase.java > 41d43c0 > > test/src/test/java/org/apache/sqoop/integration/connector/kafka/FromHDFSToKafkaTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/29140/diff/ > > > Testing > ------- > > Unit and integration tests > > > Thanks, > > Gwen Shapira > >
