> On Dec. 19, 2014, 11:13 a.m., Abraham Elmahrek wrote: > > execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor.java, > > lines 88-93 > > <https://reviews.apache.org/r/29260/diff/1/?file=797272#file797272line88> > > > > Is it possible to reuse the existing job context that's passed at > > construction? > > Veena Basavaraj wrote: > I do use that one from SqoopNullOutputFormat > > @Override > public RecordWriter<SqoopWritable, NullWritable> > getRecordWriter(TaskAttemptContext context) { > SqoopOutputFormatLoadExecutor executor = new > SqoopOutputFormatLoadExecutor(context); > return executor.getRecordWriter(context); > } > > Abraham Elmahrek wrote: > Got it. I think I see why you did this. We have a constructor exposed for > testing purposes where we may not have the context set.
yes. let me see if thee is any other way - Veena ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29260/#review65651 ----------------------------------------------------------- On Dec. 19, 2014, 10:26 a.m., Veena Basavaraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29260/ > ----------------------------------------------------------- > > (Updated Dec. 19, 2014, 10:26 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1929 > https://issues.apache.org/jira/browse/SQOOP-1929 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > see jira > > > Diffs > ----- > > common/src/main/java/org/apache/sqoop/submission/counter/SqoopCounters.java > 75f3980 > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcLoader.java > 6340a70 > > connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsExtractor.java > 3c417b4 > > connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsLoader.java > 05b0230 > > connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteLoader.java > 709fd94 > execution/mapreduce/pom.xml b23b905 > > execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopNullOutputFormat.java > 6134106 > > execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor.java > aaf771c > execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMapReduce.java > 47696cc > > execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestSqoopOutputFormatLoadExecutor.java > ec0e886 > spi/src/main/java/org/apache/sqoop/job/etl/Loader.java 3b6bd71 > > Diff: https://reviews.apache.org/r/29260/diff/ > > > Testing > ------- > > need to figure out a way to assert these value is set. > > > Thanks, > > Veena Basavaraj > >
