-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29260/
-----------------------------------------------------------

(Updated Dec. 19, 2014, 1:40 p.m.)


Review request for Sqoop.


Changes
-------

cleaned the code, since I could use the context instance field in the executor, 
so we dont need to pass it to the record writer.
fixed all the isTest cr**, we dont need it. insteaf we use mocks.


Bugs: SQOOP-1929
    https://issues.apache.org/jira/browse/SQOOP-1929


Repository: sqoop-sqoop2


Description
-------

see jira

2014-12-19 13:01:16 PST: SUCCEEDED 
Counters:
        org.apache.hadoop.mapreduce.JobCounter
                SLOTS_MILLIS_MAPS: 353532
                MB_MILLIS_MAPS: 362016768
                TOTAL_LAUNCHED_MAPS: 10
                MILLIS_MAPS: 353532
                VCORES_MILLIS_MAPS: 353532
                OTHER_LOCAL_MAPS: 10
        org.apache.hadoop.mapreduce.lib.input.FileInputFormatCounter
                BYTES_READ: 0
        org.apache.hadoop.mapreduce.lib.output.FileOutputFormatCounter
                BYTES_WRITTEN: 0
        org.apache.hadoop.mapreduce.TaskCounter
                MAP_INPUT_RECORDS: 0
                MERGED_MAP_OUTPUTS: 0
                PHYSICAL_MEMORY_BYTES: 4084232192
                SPILLED_RECORDS: 0
                FAILED_SHUFFLE: 0
                CPU_MILLISECONDS: 235120
                COMMITTED_HEAP_BYTES: 3487039488
                VIRTUAL_MEMORY_BYTES: 15284928512
                MAP_OUTPUT_RECORDS: 1000000
                SPLIT_RAW_BYTES: 1187
                GC_TIME_MILLIS: 7279
        org.apache.hadoop.mapreduce.FileSystemCounter
                FILE_READ_OPS: 0
                FILE_WRITE_OPS: 0
                FILE_BYTES_READ: 0
                FILE_LARGE_READ_OPS: 0
                HDFS_BYTES_READ: 1187
                FILE_BYTES_WRITTEN: 1198200
                HDFS_LARGE_READ_OPS: 0
                HDFS_BYTES_WRITTEN: 263888896
                HDFS_READ_OPS: 10
                HDFS_WRITE_OPS: 10
        org.apache.sqoop.submission.counter.SqoopCounters
                ROWS_WRITTEN: 1000000
                ROWS_READ: 1000000
Job executed successfully
sqoop:000> 


Diffs (updated)
-----

  common/src/main/java/org/apache/sqoop/submission/counter/SqoopCounters.java 
75f3980 
  
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcLoader.java
 6340a70 
  
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsExtractor.java
 3c417b4 
  
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsLoader.java
 05b0230 
  
connector/connector-kafka/src/main/java/org/apache/sqoop/connector/kafka/KafkaLoader.java
 5d79516 
  
connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteLoader.java
 709fd94 
  execution/mapreduce/pom.xml b23b905 
  
execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor.java
 aaf771c 
  execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMapReduce.java 
47696cc 
  
execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestSqoopOutputFormatLoadExecutor.java
 ec0e886 
  spi/src/main/java/org/apache/sqoop/job/etl/Loader.java 3b6bd71 

Diff: https://reviews.apache.org/r/29260/diff/


Testing
-------

need to figure out a way to assert these value is set.


Thanks,

Veena Basavaraj

Reply via email to