> On Dec. 17, 2014, 2:53 a.m., Veena Basavaraj wrote: > > connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteExtractor.java, > > line 61 > > <https://reviews.apache.org/r/29090/diff/2/?file=792928#file792928line61> > > > > we need to convert it to the write object types for date, which version > > of avro are we suing, does it not support date types yet? > > > > see an example in GenericJDBCConnector
Will fix in SQOOP-1616 > On Dec. 17, 2014, 2:53 a.m., Veena Basavaraj wrote: > > connector/connector-kite/src/test/java/org/apache/sqoop/connector/kite/TestKiteExtractor.java, > > line 84 > > <https://reviews.apache.org/r/29090/diff/2/?file=792938#file792938line84> > > > > can we also test cases for different data types, so how does it handle > > date-time or array? if it is writing it as object array are we making sure > > it passes the actual IDF formats for objects? > > > > https://cwiki.apache.org/confluence/display/SQOOP/Intermediate+Data+Format+API#IntermediateDataFormatAPI-1.99.5SQOOPCSVandObjectFormat Will fix in SQOOP-1616 - Qian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29090/#review65227 ----------------------------------------------------------- On Dec. 23, 2014, 3:02 p.m., Qian Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29090/ > ----------------------------------------------------------- > > (Updated Dec. 23, 2014, 3:02 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1647 > https://issues.apache.org/jira/browse/SQOOP-1647 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > This JIRA proposes to support reading data from an HDFS dataset. > > Here are two notes: > 1. Due to a review board warning, I moved new code from KiteDataTypeUtil.java > to AvroDataTypeUtil. > 2. Kite SDK seems have limitation of opening multiple record reader instances > by Sqoop 2's demand. This version supports only one > partition.https://groups.google.com/a/cloudera.org/forum/#!mydiscussions/cdk-dev/2NJUvh0WmoY > > > Diffs > ----- > > > connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteConnector.java > c864882 > > connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteConnectorError.java > d67c8de > > connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteDatasetExecutor.java > 9432e4b > > connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteDatasetPartition.java > PRE-CREATION > > connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteDatasetPartitioner.java > PRE-CREATION > > connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteExtractor.java > PRE-CREATION > > connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteFromDestroyer.java > PRE-CREATION > > connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteFromInitializer.java > PRE-CREATION > > connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteLoader.java > 0a46f4a > > connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteToDestroyer.java > 25912b4 > > connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteToInitializer.java > 11233a8 > > connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/configuration/FromJobConfig.java > PRE-CREATION > > connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/configuration/FromJobConfiguration.java > PRE-CREATION > > connector/connector-kite/src/main/resources/kite-connector-config.properties > 27c77b4 > > connector/connector-kite/src/test/java/org/apache/sqoop/connector/kite/TestKiteExecutor.java > 5e4edc5 > > connector/connector-kite/src/test/java/org/apache/sqoop/connector/kite/TestKiteExtractor.java > PRE-CREATION > > connector/connector-kite/src/test/java/org/apache/sqoop/connector/kite/TestKiteFromInitializer.java > PRE-CREATION > > connector/connector-kite/src/test/java/org/apache/sqoop/connector/kite/TestKiteToDestroyer.java > 4051fda > > connector/connector-kite/src/test/java/org/apache/sqoop/connector/kite/TestKiteToInitializer.java > 5f0525d > connector/connector-sdk/pom.xml 38c217a > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/common/AvroDataTypeUtil.java > PRE-CREATION > pom.xml afdeb75 > > Diff: https://reviews.apache.org/r/29090/diff/ > > > Testing > ------- > > Added new test cases. > > > Thanks, > > Qian Xu > >
