> On Dec. 20, 2014, 5:17 a.m., Ryan Blue wrote: > > connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteDatasetPartitioner.java, > > line 43 > > <https://reviews.apache.org/r/29090/diff/2/?file=792927#file792927line43> > > > > This is right that it isn't any more efficient to partition an > > un-partitioned dataset. But a partitioned dataset could return partitions. > > We can implement it later.
Will fix in SQOOP-1942 > On Dec. 20, 2014, 5:17 a.m., Ryan Blue wrote: > > connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteFromInitializer.java, > > line 46 > > <https://reviews.apache.org/r/29090/diff/2/?file=792930#file792930line46> > > > > Why doesn't this call `Datasets.exists` directly? At that time I planed to wrap kite sdk usage in `KiteDatasetExecutor`. But I think it is over-designed. > On Dec. 20, 2014, 5:17 a.m., Ryan Blue wrote: > > connector/connector-kite/src/main/resources/kite-connector-config.properties, > > line 38 > > <https://reviews.apache.org/r/29090/diff/2/?file=792936#file792936line38> > > > > Without "store", this no longer makes sense. I would change it to > > "Dataset URI" because that could be used for both from and to URIs. I've added "store" and "load" back. We have `toJobConfig.uri` and `fromJobConfig.uri`. - Qian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29090/#review65564 ----------------------------------------------------------- On Dec. 23, 2014, 3:02 p.m., Qian Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29090/ > ----------------------------------------------------------- > > (Updated Dec. 23, 2014, 3:02 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1647 > https://issues.apache.org/jira/browse/SQOOP-1647 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > This JIRA proposes to support reading data from an HDFS dataset. > > Here are two notes: > 1. Due to a review board warning, I moved new code from KiteDataTypeUtil.java > to AvroDataTypeUtil. > 2. Kite SDK seems have limitation of opening multiple record reader instances > by Sqoop 2's demand. This version supports only one > partition.https://groups.google.com/a/cloudera.org/forum/#!mydiscussions/cdk-dev/2NJUvh0WmoY > > > Diffs > ----- > > > connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteConnector.java > c864882 > > connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteConnectorError.java > d67c8de > > connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteDatasetExecutor.java > 9432e4b > > connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteDatasetPartition.java > PRE-CREATION > > connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteDatasetPartitioner.java > PRE-CREATION > > connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteExtractor.java > PRE-CREATION > > connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteFromDestroyer.java > PRE-CREATION > > connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteFromInitializer.java > PRE-CREATION > > connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteLoader.java > 0a46f4a > > connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteToDestroyer.java > 25912b4 > > connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteToInitializer.java > 11233a8 > > connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/configuration/FromJobConfig.java > PRE-CREATION > > connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/configuration/FromJobConfiguration.java > PRE-CREATION > > connector/connector-kite/src/main/resources/kite-connector-config.properties > 27c77b4 > > connector/connector-kite/src/test/java/org/apache/sqoop/connector/kite/TestKiteExecutor.java > 5e4edc5 > > connector/connector-kite/src/test/java/org/apache/sqoop/connector/kite/TestKiteExtractor.java > PRE-CREATION > > connector/connector-kite/src/test/java/org/apache/sqoop/connector/kite/TestKiteFromInitializer.java > PRE-CREATION > > connector/connector-kite/src/test/java/org/apache/sqoop/connector/kite/TestKiteToDestroyer.java > 4051fda > > connector/connector-kite/src/test/java/org/apache/sqoop/connector/kite/TestKiteToInitializer.java > 5f0525d > connector/connector-sdk/pom.xml 38c217a > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/common/AvroDataTypeUtil.java > PRE-CREATION > pom.xml afdeb75 > > Diff: https://reviews.apache.org/r/29090/diff/ > > > Testing > ------- > > Added new test cases. > > > Thanks, > > Qian Xu > >
