> On Dec. 23, 2014, 7:45 a.m., Qian Xu wrote: > > common-test/src/main/java/org/apache/sqoop/common/test/db/DerbyProvider.java, > > line 87 > > <https://reviews.apache.org/r/28678/diff/2/?file=785069#file785069line87> > > > > Maybe you can do a favor to fix the error message. > > String message = "Cannot start the embedded server"; > > LOG.fatal(message, e); > > throw new RuntimeException(message, e);
The change has been already committed, so would you mind opening a new JIRA for this improvement? > On Dec. 23, 2014, 7:45 a.m., Qian Xu wrote: > > common-test/src/main/java/org/apache/sqoop/common/test/db/DerbyProvider.java, > > line 103 > > <https://reviews.apache.org/r/28678/diff/2/?file=785069#file785069line103> > > > > If you want to wrap the exception then log as fatal, otherwise let the > > exception go out. > > > > String message = "Cannot shut down the embedded server"; > > LOG.fatal(message, e); > > throw new RuntimeException(message, e); I believe that entire stack trace will be logged regardless of what level we will use to log the message - as long as the level is allowed to be printed out (which should be the case for "info"). - Jarek ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28678/#review65880 ----------------------------------------------------------- On Dec. 7, 2014, 4:38 p.m., Jarek Cecho wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28678/ > ----------------------------------------------------------- > > (Updated Dec. 7, 2014, 4:38 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1840 > https://issues.apache.org/jira/browse/SQOOP-1840 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > I've added the explicit timeout and guarded call to server.stop(). > > > Diffs > ----- > > > common-test/src/main/java/org/apache/sqoop/common/test/db/DerbyProvider.java > 2597325 > > Diff: https://reviews.apache.org/r/28678/diff/ > > > Testing > ------- > > Seems to be working for me well for both positive and negative case. > > 1) Tried case when there is nothing wrong and the tests are passing > 2) Tried case when that would otherwise lead to infinite loop and the test > failed fast. > > > Thanks, > > Jarek Cecho > >
