----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28678/#review65888 -----------------------------------------------------------
Ship it! Ship It! - Qian Xu On Dec. 8, 2014, 12:38 a.m., Jarek Cecho wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28678/ > ----------------------------------------------------------- > > (Updated Dec. 8, 2014, 12:38 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1840 > https://issues.apache.org/jira/browse/SQOOP-1840 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > I've added the explicit timeout and guarded call to server.stop(). > > > Diffs > ----- > > > common-test/src/main/java/org/apache/sqoop/common/test/db/DerbyProvider.java > 2597325 > > Diff: https://reviews.apache.org/r/28678/diff/ > > > Testing > ------- > > Seems to be working for me well for both positive and negative case. > > 1) Tried case when there is nothing wrong and the tests are passing > 2) Tried case when that would otherwise lead to infinite loop and the test > failed fast. > > > Thanks, > > Jarek Cecho > >
