----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29392/#review66044 -----------------------------------------------------------
core/src/main/java/org/apache/sqoop/repository/Repository.java <https://reviews.apache.org/r/29392/#comment109389> godo catch. Wonder how kafka connector tested the upgrade path when this was broken? lgtm!, we need to add this use case to the derby integration test, do you think we can create a connector with only FROM or TO in the data set ? - Veena Basavaraj On Dec. 24, 2014, 12:22 a.m., Qian Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29392/ > ----------------------------------------------------------- > > (Updated Dec. 24, 2014, 12:22 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1624 > https://issues.apache.org/jira/browse/SQOOP-1624 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > Create a standard Upgrader class for Kite Connector. Note that when validate > the implementation, I saw a NPE. The root cause is that the current Kite > connector does not have a TO direction implementation. The patch contains a > fix for that. > > > Diffs > ----- > > > connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteConnector.java > c864882 > > connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteConnectorUpgrader.java > PRE-CREATION > core/src/main/java/org/apache/sqoop/repository/Repository.java 9461afe > > Diff: https://reviews.apache.org/r/29392/diff/ > > > Testing > ------- > > No new test cases. > > > Thanks, > > Qian Xu > >
