> On Dec. 24, 2014, 11:38 p.m., Veena Basavaraj wrote: > > core/src/main/java/org/apache/sqoop/repository/Repository.java, line 474 > > <https://reviews.apache.org/r/29392/diff/1/?file=800126#file800126line474> > > > > godo catch. Wonder how kafka connector tested the upgrade path when > > this was broken? > > > > lgtm!, we need to add this use case to the derby integration test, do > > you think we can create a connector with only FROM or TO in the data set ? > > Qian Xu wrote: > There are still no upgrade support for Kafka and Kite connectors. As > connector api provides a `getSupportedDirections`, I believe one direction > connector should work by design. > > Veena Basavaraj wrote: > I understand, but kafka connector is in the code base, and if the we > actually run the upgrade code for connectors, it would be broken without this > fix, this is what I meant. > > second, the data set in Derby1_99_4UpgradeTest needs to be enhanced to > add a connector which supports only one direction, or we need to keep adding > more of such upgrade tests as we discover these issues > > /** > * This version contains the following structures: > * Generic JDBC Connector link with name "Link1" and id 1 > * Generic JDBC Connector link with blank name and id 2 > * HDFS Connector link with name "Link3" and id 3 > * HDFS Connector link with blank name and id 4 > * HDFS Connector link with blank name and id 5 > * HDFS Connector link with blank name and id 6
In 1.99.3 there are no Kite/Kafka connector, so when upgrade to 1.99.4, upgrade path will not check Kite/Kafka. They are safe. It is worth having a test case in the future, if Kite/Kafka connectors still have only one direction support. I've created a follow up SQOOP-1958. - Qian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29392/#review66044 ----------------------------------------------------------- On Dec. 24, 2014, 4:22 p.m., Qian Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29392/ > ----------------------------------------------------------- > > (Updated Dec. 24, 2014, 4:22 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1624 > https://issues.apache.org/jira/browse/SQOOP-1624 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > Create a standard Upgrader class for Kite Connector. Note that when validate > the implementation, I saw a NPE. The root cause is that the current Kite > connector does not have a TO direction implementation. The patch contains a > fix for that. > > > Diffs > ----- > > > connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteConnector.java > c864882 > > connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteConnectorUpgrader.java > PRE-CREATION > core/src/main/java/org/apache/sqoop/repository/Repository.java 9461afe > > Diff: https://reviews.apache.org/r/29392/diff/ > > > Testing > ------- > > No new test cases. > > > Thanks, > > Qian Xu > >
