----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29566/#review66606 -----------------------------------------------------------
Ship it! Ship It! - Qian Xu On Jan. 4, 2015, 4:02 p.m., Qian Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29566/ > ----------------------------------------------------------- > > (Updated Jan. 4, 2015, 4:02 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1963 > https://issues.apache.org/jira/browse/SQOOP-1963 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > If we run mvn eclipse:eclipse before mvn package, the generated files such as > .project, .classpath, .settings files are included in source distribution > under dist/target/sqoop-2.0.0-SNAPSHOT folders. > The generated files should not be included in the source distribution. One of > direct impact caused by this bug is when import Sqoop2 projects into eclipse, > eclipse will list duplicated project names search from the root directory if > we run mvn package after mvn eclipse:eclipse. This will cause project import > to fail. > > > Diffs > ----- > > dist/pom.xml cc11072 > > Diff: https://reviews.apache.org/r/29566/diff/ > > > Testing > ------- > > > Thanks, > > Qian Xu > >
