> On Jan. 6, 2015, 8 a.m., Jerry Chen wrote: > > Can we simply reuse an existing ResourceRequest instance such as > > VersionResourceRequest other than create new a ResourceRequest?
I have thought about it for a while. Though it could save some code, but it does not make total sense logically, since this function belongs to basic ResourceRequest, not a specific ResourceRequest instance, ie. VersionResourceRequest. What do you think? - richard ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29619/#review66802 ----------------------------------------------------------- On Jan. 6, 2015, 7:21 a.m., richard zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29619/ > ----------------------------------------------------------- > > (Updated Jan. 6, 2015, 7:21 a.m.) > > > Review request for Sqoop and Jerry Chen. > > > Repository: sqoop-sqoop2 > > > Description > ------- > > addDelegationTokens is not exposed in SqoopClient > > > Diffs > ----- > > client/src/main/java/org/apache/sqoop/client/SqoopClient.java > e1f009cd517caa139a5525735df2c980a2e75d5e > > client/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.java > fe528f26e0bbc9411ae0b37b0b2c3f4ebe19634c > > Diff: https://reviews.apache.org/r/29619/diff/ > > > Testing > ------- > > local test > > > Thanks, > > richard zhou > >
