>> I have thought about it for a while. Though it could save some code, but it >> does not make total sense logically, since this function belongs to basic >> ResourceRequest, not a specific ResourceRequest instance, ie. >> VersionResourceRequest. That means you should move out addDelegationToken from ResourceRequest or make addDelegationToken method static in ResourceRequest.
Create a new member and instance of ResourceRequest in the ResourceRequests just for calling addDelelgationToken makes no sense too. From: richard zhou [mailto:[email protected]] On Behalf Of richard zhou Sent: Tuesday, January 6, 2015 4:07 PM To: Chen, Haifeng Cc: Zhou, Richard; Sqoop Subject: Re: Review Request 29619: SQOOP2: addDelegationTokens is not exposed in SqoopClient This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29619/ On January 6th, 2015, 8 a.m. UTC, Jerry Chen wrote: Can we simply reuse an existing ResourceRequest instance such as VersionResourceRequest other than create new a ResourceRequest? I have thought about it for a while. Though it could save some code, but it does not make total sense logically, since this function belongs to basic ResourceRequest, not a specific ResourceRequest instance, ie. VersionResourceRequest. What do you think? - richard On January 6th, 2015, 7:21 a.m. UTC, richard zhou wrote: Review request for Sqoop and Jerry Chen. By richard zhou. Updated Jan. 6, 2015, 7:21 a.m. Repository: sqoop-sqoop2 Description addDelegationTokens is not exposed in SqoopClient Testing local test Diffs * client/src/main/java/org/apache/sqoop/client/SqoopClient.java (e1f009cd517caa139a5525735df2c980a2e75d5e) * client/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.java (fe528f26e0bbc9411ae0b37b0b2c3f4ebe19634c) View Diff<https://reviews.apache.org/r/29619/diff/>
