----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29621/#review66804 -----------------------------------------------------------
I don't think it is the right way to use static member in the ResourceRequest to share the AuthToken. Because multiple SqoopClient instances will mix up the token. I would suggest to add an overload constructor with a parameter of AuthToken which is passed from externally. (Please note to keep the original constructor with no parameters. In this way, it can be shared when it passed. If the parameter is passed with null, it should new a non-shared token instance internally. public ResourceRequest() public ResourceRequest(DelegationTokenAuthenticatedURL.Token authToken) - Jerry Chen On Jan. 6, 2015, 8:02 a.m., richard zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29621/ > ----------------------------------------------------------- > > (Updated Jan. 6, 2015, 8:02 a.m.) > > > Review request for Sqoop and Jerry Chen. > > > Repository: sqoop-sqoop2 > > > Description > ------- > > Share auth token across ResourceRequest in SqoopClient* > > > Diffs > ----- > > client/src/main/java/org/apache/sqoop/client/request/ResourceRequest.java > e55ba360bea845a0acc677fa204a27e708adc53c > > Diff: https://reviews.apache.org/r/29621/diff/ > > > Testing > ------- > > local test > > > Thanks, > > richard zhou > >
