-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29621/#review67181
-----------------------------------------------------------


public ResourceRequest(DelegationTokenAuthenticatedURL.Token token) {
    this.authToken = token;
  }
For this, please check whethen the token is null or not, if it is null, please 
new a token just the same as no token object passed in.

- Jerry Chen


On Jan. 8, 2015, 8:35 a.m., richard zhou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29621/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2015, 8:35 a.m.)
> 
> 
> Review request for Sqoop and Jerry Chen.
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> Share auth token across ResourceRequest in SqoopClient*
> 
> 
> Diffs
> -----
> 
>   
> client/src/main/java/org/apache/sqoop/client/request/ConnectorResourceRequest.java
>  c6232d0bf923a666eaa5e961c5a18d4ac0f6181f 
>   
> client/src/main/java/org/apache/sqoop/client/request/DriverResourceRequest.java
>  95bb12cbb7cba0c601133ec832ef2fe6a553dab7 
>   
> client/src/main/java/org/apache/sqoop/client/request/JobResourceRequest.java 
> 167e8be46fb7aa77ef99f18584891430050b1b9b 
>   
> client/src/main/java/org/apache/sqoop/client/request/LinkResourceRequest.java 
> 9a4a134f183eedeea09af4f42a7012a809a7de42 
>   client/src/main/java/org/apache/sqoop/client/request/ResourceRequest.java 
> e55ba360bea845a0acc677fa204a27e708adc53c 
>   
> client/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.java
>  fe528f26e0bbc9411ae0b37b0b2c3f4ebe19634c 
>   
> client/src/main/java/org/apache/sqoop/client/request/SubmissionResourceRequest.java
>  47a0a941b9c44c7a0ed37ac4e0e22f9ce6ad07b6 
>   
> client/src/main/java/org/apache/sqoop/client/request/VersionResourceRequest.java
>  7bd0dba75cddd670313b273519eca2ff12fb87a3 
> 
> Diff: https://reviews.apache.org/r/29621/diff/
> 
> 
> Testing
> -------
> 
> local test
> 
> 
> Thanks,
> 
> richard zhou
> 
>

Reply via email to