----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29817/ -----------------------------------------------------------
Review request for Sqoop. Repository: sqoop-sqoop2 Description ------- Adds missing test cases for null handling in Avro and JSON IDF enhanced the test cases in CSV IDF to throw an exception when a value is null and isNullable is false minor renames of variables to keep code consistent across the 3 IDfs. Diffs ----- connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/AVROIntermediateDataFormat.java 67b47e7 connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormat.java 856a4bb connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/IntermediateDataFormat.java 261a462 connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/IntermediateDataFormatError.java 1f583b2 connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/JSONIntermediateDataFormat.java b937d87 connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestAVROIntermediateDataFormat.java 816cc71 connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java fca410f connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestJSONIntermediateDataFormat.java 44ea4fd Diff: https://reviews.apache.org/r/29817/diff/ Testing ------- yes Thanks, Veena Basavaraj
