> On Jan. 13, 2015, 9:49 a.m., Qian Xu wrote: > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/AVROIntermediateDataFormat.java, > > line 76 > > <https://reviews.apache.org/r/29817/diff/2/?file=818016#file818016line76> > > > > Validate schema wants to ensure the schema is not null. Why validate > > schema in every get/set Data or CSVTextData method. Is there any reason for > > that? > > Veena Basavaraj wrote: > good question. I initialy did think it might be too costly, but all it > does is check for null today. validate might sound like a heavy operation. > > On why we do it every method, because there is no way to ensure this in > one place because of the default no arg constructor we have for the sake of > reflection, we can call the get/ set methods ( the 6 of them) without any > order imposed.
Sorry for my insist, I've create SQOOP-2006. - Qian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29817/#review67776 ----------------------------------------------------------- On Jan. 13, 2015, 6:10 a.m., Veena Basavaraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29817/ > ----------------------------------------------------------- > > (Updated Jan. 13, 2015, 6:10 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1995 > https://issues.apache.org/jira/browse/SQOOP-1995 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > Adds missing test cases for null handling in Avro and JSON IDF > enhanced the test cases in CSV IDF to throw an exception when a value is null > and isNullable is false > minor renames of variables to keep code consistent across the 3 IDfs. > > > Diffs > ----- > > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/AVROIntermediateDataFormat.java > 67b47e7 > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/AVROIntermediateDataFormatError.java > 6af21a3 > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormat.java > 856a4bb > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/IntermediateDataFormat.java > 261a462 > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/IntermediateDataFormatError.java > 1f583b2 > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/JSONIntermediateDataFormat.java > b937d87 > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/JSONIntermediateDataFormatError.java > 86c71b6 > > connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestAVROIntermediateDataFormat.java > 816cc71 > > connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java > fca410f > > connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestJSONIntermediateDataFormat.java > 44ea4fd > > Diff: https://reviews.apache.org/r/29817/diff/ > > > Testing > ------- > > yes > > > Thanks, > > Veena Basavaraj > >
