----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29836/#review67845 -----------------------------------------------------------
core/src/main/java/org/apache/sqoop/security/AuthorizationAccessController.java <https://reviews.apache.org/r/29836/#comment111930> If there is no LOG usage, we can remove it (incl. imports) core/src/main/java/org/apache/sqoop/security/AuthorizationHandler.java <https://reviews.apache.org/r/29836/#comment111931> dito core/src/main/java/org/apache/sqoop/security/AuthorizationManager.java <https://reviews.apache.org/r/29836/#comment111932> Remove the check, as other occurences do not have the check. core/src/main/java/org/apache/sqoop/security/AuthorizationManager.java <https://reviews.apache.org/r/29836/#comment111934> nit: three get string can be wrapped into a private `getContextString` public synchronized void initialize() ... { Context context = SqoopConfiguration.getInstance().getContext(); String accessController = getContextString(context, SecurityConstants.AUTHORIZATION_HANDLER, DEFAULT_AUTHORIZATION_HANDLER); String handler = getContextString(...); } private static String getContextString(Context context, String key, String fallback) { return context.getString(key, fallback).trim(); } core/src/main/java/org/apache/sqoop/security/AuthorizationManager.java <https://reviews.apache.org/r/29836/#comment111933> Remove the check, as other occurences do not have the check. core/src/main/java/org/apache/sqoop/security/AuthorizationValidator.java <https://reviews.apache.org/r/29836/#comment111935> dito core/src/main/java/org/apache/sqoop/security/SecurityFactory.java <https://reviews.apache.org/r/29836/#comment111936> Exception message is not informative. core/src/main/java/org/apache/sqoop/security/SecurityFactory.java <https://reviews.apache.org/r/29836/#comment111937> dito core/src/main/java/org/apache/sqoop/security/SecurityFactory.java <https://reviews.apache.org/r/29836/#comment111938> dito security/src/main/java/org/apache/sqoop/security/Authorization/DefaultAuthorizationAccessController.java <https://reviews.apache.org/r/29836/#comment111939> clean up security/src/main/java/org/apache/sqoop/security/Authorization/DefaultAuthorizationHandler.java <https://reviews.apache.org/r/29836/#comment111940> clean up security/src/main/java/org/apache/sqoop/security/Authorization/DefaultAuthorizationValidator.java <https://reviews.apache.org/r/29836/#comment111941> clean up - Qian Xu On Jan. 13, 2015, 10:33 a.m., richard zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29836/ > ----------------------------------------------------------- > > (Updated Jan. 13, 2015, 10:33 a.m.) > > > Review request for Sqoop. > > > Repository: sqoop-sqoop2 > > > Description > ------- > > Add a empty pluggable RBAC framework. API will be added in the following JIRA. > > > Diffs > ----- > > core/src/main/java/org/apache/sqoop/core/SqoopServer.java > fe467e31cf5337b46c9cb94f671c142e50eaf1c6 > > core/src/main/java/org/apache/sqoop/security/AuthorizationAccessController.java > PRE-CREATION > core/src/main/java/org/apache/sqoop/security/AuthorizationHandler.java > PRE-CREATION > core/src/main/java/org/apache/sqoop/security/AuthorizationManager.java > PRE-CREATION > core/src/main/java/org/apache/sqoop/security/AuthorizationValidator.java > PRE-CREATION > core/src/main/java/org/apache/sqoop/security/SecurityConstants.java > a00573aeccc01acb1daee65119068f4be2acfb94 > core/src/main/java/org/apache/sqoop/security/SecurityError.java > e4ba22126b2d8e26e7f3f1835637d5f6c6e8a8d0 > core/src/main/java/org/apache/sqoop/security/SecurityFactory.java > 3e6df6729fbf87868fa623c56b6f586ae23a43d3 > dist/src/main/server/conf/sqoop.properties > e22e8b06bd21a18a4b43d1e29e54ae75400ba997 > > security/src/main/java/org/apache/sqoop/security/Authorization/DefaultAuthorizationAccessController.java > PRE-CREATION > > security/src/main/java/org/apache/sqoop/security/Authorization/DefaultAuthorizationHandler.java > PRE-CREATION > > security/src/main/java/org/apache/sqoop/security/Authorization/DefaultAuthorizationValidator.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/29836/diff/ > > > Testing > ------- > > local test > integration test > > > Thanks, > > richard zhou > >
