> On Jan. 13, 2015, 6:29 p.m., Abraham Elmahrek wrote: > > core/src/main/java/org/apache/sqoop/security/AuthorizationValidator.java, > > line 25 > > <https://reviews.apache.org/r/29836/diff/2/?file=818635#file818635line25> > > > > Should this have some methods like "has_perm" or something similar? > > richard zhou wrote: > Yes, you are correct, there should be some abstract functions like > "checkPrivilege" inside, according to the [high level > design|https://cwiki.apache.org/confluence/display/SQOOP/High+Level+Design+of+Role+Based+Access+Controller]. > However, it is a first patch, with empty framework. The detail APIs will be > added in the following JIRA. > What do you think? Do you need it in in this patch?
Thanks for providing clarity. Up to you at the end of the day. - Abraham ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29836/#review67896 ----------------------------------------------------------- On Jan. 13, 2015, 2:33 a.m., richard zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29836/ > ----------------------------------------------------------- > > (Updated Jan. 13, 2015, 2:33 a.m.) > > > Review request for Sqoop. > > > Repository: sqoop-sqoop2 > > > Description > ------- > > Add a empty pluggable RBAC framework. API will be added in the following JIRA. > > > Diffs > ----- > > core/src/main/java/org/apache/sqoop/core/SqoopServer.java > fe467e31cf5337b46c9cb94f671c142e50eaf1c6 > > core/src/main/java/org/apache/sqoop/security/AuthorizationAccessController.java > PRE-CREATION > core/src/main/java/org/apache/sqoop/security/AuthorizationHandler.java > PRE-CREATION > core/src/main/java/org/apache/sqoop/security/AuthorizationManager.java > PRE-CREATION > core/src/main/java/org/apache/sqoop/security/AuthorizationValidator.java > PRE-CREATION > core/src/main/java/org/apache/sqoop/security/SecurityConstants.java > a00573aeccc01acb1daee65119068f4be2acfb94 > core/src/main/java/org/apache/sqoop/security/SecurityError.java > e4ba22126b2d8e26e7f3f1835637d5f6c6e8a8d0 > core/src/main/java/org/apache/sqoop/security/SecurityFactory.java > 3e6df6729fbf87868fa623c56b6f586ae23a43d3 > dist/src/main/server/conf/sqoop.properties > e22e8b06bd21a18a4b43d1e29e54ae75400ba997 > > security/src/main/java/org/apache/sqoop/security/Authorization/DefaultAuthorizationAccessController.java > PRE-CREATION > > security/src/main/java/org/apache/sqoop/security/Authorization/DefaultAuthorizationHandler.java > PRE-CREATION > > security/src/main/java/org/apache/sqoop/security/Authorization/DefaultAuthorizationValidator.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/29836/diff/ > > > Testing > ------- > > local test > integration test > > > Thanks, > > richard zhou > >
