[ 
https://issues.apache.org/jira/browse/SQOOP-2007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14278158#comment-14278158
 ] 

Qian Xu commented on SQOOP-2007:
--------------------------------

I'll propose a patch later. I think we should determine the output order in 
constructor. It will be faster in general. And furthermore, we should not only 
make sure the column names are identical but also make sure the column types 
are identical.

> Schema NameMatcher cleanup
> --------------------------
>
>                 Key: SQOOP-2007
>                 URL: https://issues.apache.org/jira/browse/SQOOP-2007
>             Project: Sqoop
>          Issue Type: Sub-task
>            Reporter: Veena Basavaraj
>             Fix For: 2.0.0
>
>
> {code}
>  fromColNameIndexMap = new HashMap<String, Integer>();
>     int fromIndex = 0;
>     for (Column fromCol : getFromSchema().getColumnsList()) {
>       fromColNameIndexMap.put(fromCol.getName(), fromIndex);
>       fromIndex++;
>     }
> {code}
> we can clean this code up, since this index map is already in schema now, 
> since e needed it for JSON and Avro IDF



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to