[
https://issues.apache.org/jira/browse/SQOOP-2007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14278186#comment-14278186
]
Veena Basavaraj commented on SQOOP-2007:
----------------------------------------
[~stanleyxu2005] It is lookup so I am not sure what needs to be done in
constructor? I infact have a patch was waiting until is isNull removal code is
in, so I can rebase. Very very good point on checking type.
More tests can be added to Name mactcher for these cases
> Schema NameMatcher cleanup
> --------------------------
>
> Key: SQOOP-2007
> URL: https://issues.apache.org/jira/browse/SQOOP-2007
> Project: Sqoop
> Issue Type: Sub-task
> Reporter: Veena Basavaraj
> Fix For: 2.0.0
>
>
> {code}
> fromColNameIndexMap = new HashMap<String, Integer>();
> int fromIndex = 0;
> for (Column fromCol : getFromSchema().getColumnsList()) {
> fromColNameIndexMap.put(fromCol.getName(), fromIndex);
> fromIndex++;
> }
> {code}
> we can clean this code up, since this index map is already in schema now,
> since e needed it for JSON and Avro IDF
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
