> On Jan. 16, 2015, 3:16 p.m., Abraham Elmahrek wrote: > > LGTM
I have updated the IDF wiki as well, that we will use twice the maxSize of INT if it is unsigned. - Veena ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29980/#review68487 ----------------------------------------------------------- On Jan. 16, 2015, 1:52 p.m., Veena Basavaraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29980/ > ----------------------------------------------------------- > > (Updated Jan. 16, 2015, 1:52 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-2022 > https://issues.apache.org/jira/browse/SQOOP-2022 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > see jira > > > Diffs > ----- > > common/src/main/java/org/apache/sqoop/json/util/SchemaSerialization.java > bbd58fc > common/src/main/java/org/apache/sqoop/schema/type/FixedPoint.java 836e4ad > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/common/SqoopAvroUtils.java > c19c7f4 > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/common/SqoopIDFUtils.java > 800630f > > connector/connector-sdk/src/test/java/org/apache/sqoop/connector/common/TestSqoopIDFUtils.java > 1cef714 > > Diff: https://reviews.apache.org/r/29980/diff/ > > > Testing > ------- > > > Thanks, > > Veena Basavaraj > >
