Re: Review Request 29980: SqoopIDFUtils uses bit size instead of byteSize to check for INT/LONG/FLOAT/Double and does not handle signed/unsigned

[Veena Basavaraj]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29980/
-----------------------------------------------------------

(Updated Jan. 21, 2015, 3:06 p.m.)


Review request for Sqoop.


Bugs: SQOOP-2022
    https://issues.apache.org/jira/browse/SQOOP-2022


Repository: sqoop-sqoop2


Description
-------

see jira


Diffs (updated)
-----

  common/src/main/java/org/apache/sqoop/json/util/SchemaSerialization.java 
a6425fe 
  common/src/main/java/org/apache/sqoop/schema/type/FixedPoint.java 84a76ae 
  common/src/main/java/org/apache/sqoop/schema/type/FloatingPoint.java 4fa0c30 
  common/src/test/java/org/apache/sqoop/json/util/TestSchemaSerialization.java 
0cb7175 
  
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/util/SqlTypesUtils.java
 8228397 
  
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestExtractor.java
 83599d3 
  
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestFromInitializer.java
 249cd34 
  
connector/connector-sdk/src/main/java/org/apache/sqoop/connector/common/AvroDataTypeUtil.java
 759bd9f 
  
connector/connector-sdk/src/main/java/org/apache/sqoop/connector/common/SqoopAvroUtils.java
 d62a8a4 
  
connector/connector-sdk/src/main/java/org/apache/sqoop/connector/common/SqoopIDFUtils.java
 8630369 
  
connector/connector-sdk/src/test/java/org/apache/sqoop/connector/common/TestSqoopIDFUtils.java
 1cef714 
  
connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestAVROIntermediateDataFormat.java
 dd7a3e1 
  
connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java
 2556711 
  
connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestJSONIntermediateDataFormat.java
 12c66c2 
  execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMatching.java 
4945584 
  
execution/mapreduce/src/test/java/org/apache/sqoop/job/util/MRJobTestUtil.java 
ce39a78 
  test/src/main/java/org/apache/sqoop/test/data/Cities.java 1e90c59 
  test/src/main/java/org/apache/sqoop/test/data/UbuntuReleases.java 7979686 

Diff: https://reviews.apache.org/r/29980/diff/


Testing
-------


Thanks,

Veena Basavaraj