> On March 13, 2015, 3:22 a.m., Qian Xu wrote: > > src/test/com/cloudera/sqoop/TestAllTables.java, line 65 > > <https://reviews.apache.org/r/31839/diff/1/?file=888595#file888595line65> > > > > Better move the block upwards so that the code reader see what we do to > > args when resetMapper equals true or false.
I have removed all changes to this file and added a new file. > On March 13, 2015, 3:22 a.m., Qian Xu wrote: > > src/java/org/apache/sqoop/SqoopOptions.java, line 2504 > > <https://reviews.apache.org/r/31839/diff/1/?file=888591#file888591line2504> > > > > Always be true? If the method does not use argument `b`, then remove it. Thanks. It is removed in the modified version - Venkat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31839/#review76335 ----------------------------------------------------------- On March 9, 2015, 1:03 a.m., Venkat Ranganathan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31839/ > ----------------------------------------------------------- > > (Updated March 9, 2015, 1:03 a.m.) > > > Review request for Sqoop. > > > Repository: sqoop-trunk > > > Description > ------- > > Provides a new option autoreset-to-one-mapper which instructs sqoop to reset > the number of mappers to one when primary key is not defined for a table and > no split by column is provided (which is the case for import-all-tables). > New tests added and documentation updated > > > Diffs > ----- > > src/docs/user/import-all-tables-purpose.txt d5df88c > src/docs/user/import-all-tables.txt 166825a > src/docs/user/import.txt a6b23df > src/java/org/apache/sqoop/SqoopOptions.java 0070d0b > src/java/org/apache/sqoop/manager/SqlManager.java c81f170 > src/java/org/apache/sqoop/tool/BaseSqoopTool.java b41ee2d > src/java/org/apache/sqoop/tool/ImportTool.java d5bf1eb > src/test/com/cloudera/sqoop/TestAllTables.java 39e8941 > src/test/com/cloudera/sqoop/TestSqoopOptions.java 60460d9 > > Diff: https://reviews.apache.org/r/31839/diff/ > > > Testing > ------- > > All tests pass including newly added tests > > > Thanks, > > Venkat Ranganathan > >
