> On March 13, 2015, 2:42 p.m., Jarek Cecho wrote: > > src/java/org/apache/sqoop/tool/ImportAllTablesTool.java, line 105 > > <https://reviews.apache.org/r/31839/diff/2/?file=892749#file892749line105> > > > > This line is not entirely clear to me. Shouldn't we have copy of the > > original value and always use that instead of the default value?
Good point. I overlooked we can pass the number of mappers to import all tables tool. Let me fix this. Thanks - Venkat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31839/#review76365 ----------------------------------------------------------- On March 13, 2015, 5:16 a.m., Venkat Ranganathan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31839/ > ----------------------------------------------------------- > > (Updated March 13, 2015, 5:16 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-2191 > https://issues.apache.org/jira/browse/SQOOP-2191 > > > Repository: sqoop-trunk > > > Description > ------- > > Provides a new option autoreset-to-one-mapper which instructs sqoop to reset > the number of mappers to one when primary key is not defined for a table and > no split by column is provided (which is the case for import-all-tables). > New tests added and documentation updated > > > Diffs > ----- > > src/docs/user/import-all-tables-purpose.txt d5df88c > src/docs/user/import-all-tables.txt 166825a > src/docs/user/import.txt a6b23df > src/java/org/apache/sqoop/SqoopOptions.java 0070d0b > src/java/org/apache/sqoop/accumulo/AccumuloUtil.java 06888c5 > src/java/org/apache/sqoop/config/ConfigurationHelper.java 5e4230e > src/java/org/apache/sqoop/manager/SqlManager.java c81f170 > src/java/org/apache/sqoop/mapreduce/hcat/SqoopHCatUtilities.java ee25d0e > src/java/org/apache/sqoop/tool/BaseSqoopTool.java b41ee2d > src/java/org/apache/sqoop/tool/ImportAllTablesTool.java ab95959 > src/java/org/apache/sqoop/tool/ImportTool.java d5bf1eb > src/test/com/cloudera/sqoop/TestAvroImport.java 440e76c > src/test/com/cloudera/sqoop/TestBoundaryQuery.java dc82de2 > src/test/com/cloudera/sqoop/TestParquetImport.java 192da17 > src/test/com/cloudera/sqoop/TestSqoopOptions.java 60460d9 > src/test/com/cloudera/sqoop/testutil/ImportJobTestCase.java d5b7f8f > src/test/org/apache/sqoop/TestAutoResetMapper.java PRE-CREATION > > src/test/org/apache/sqoop/mapreduce/mainframe/TestMainframeDatasetInputFormat.java > e386fb0 > > Diff: https://reviews.apache.org/r/31839/diff/ > > > Testing > ------- > > All tests pass including newly added tests > > > Thanks, > > Venkat Ranganathan > >
